roms: simplify build_roms()

cbcfg is already a global variable, so there's no reason
to set it again at the start of this function.

remove the check for whether the given coreboot config
exists, to the calling function instead of build_roms().

Signed-off-by: Leah Rowe <leah@libreboot.org>
audit6-merge1
Leah Rowe 2024-06-16 12:46:03 +01:00
parent d3e7886450
commit 92aa83a236
1 changed files with 1 additions and 4 deletions

View File

@ -184,16 +184,13 @@ build_board()
[ "$displaymode" != "txtmode" ] && continue [ "$displaymode" != "txtmode" ] && continue
cbcfg="$targetdir/config/${initmode}_$displaymode" cbcfg="$targetdir/config/${initmode}_$displaymode"
[ "$initmode" = "normal" ] && cbcfg="${cbcfg%_*}" [ "$initmode" = "normal" ] && cbcfg="${cbcfg%_*}"
build_roms "$cbcfg"; x_ rm -f "$cbrom" e "$cbcfg" f not || build_roms; x_ rm -f "$cbrom"
done done
done done
} }
build_roms() build_roms()
{ {
cbcfg="$1"
e "$cbcfg" f not && return 0
x_ ./update trees -b coreboot $board x_ ./update trees -b coreboot $board
_cbrom="elf/coreboot_nopayload_DO_NOT_FLASH" _cbrom="elf/coreboot_nopayload_DO_NOT_FLASH"