From a98490573be7c0ac779cfc3e70220984ece486d5 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Wed, 29 Jan 2025 04:45:57 +0000 Subject: [PATCH] util/nvmutil: only set mac_updated at the end after setting the checksum too this is functionally no different, but setting it at the start didn't sit right with me. it's more logically correct to set it at the end, in case any error did not result in an exit. Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index b016e419..a28a117e 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -268,7 +268,6 @@ cmd_setmac(void) for (int partnum = 0; partnum < 2; partnum++) { if (!goodChecksum(part = partnum)) continue; - mac_updated = 1; for (int w = 0; w < 3; w++) /* write MAC to gbe part */ setWord(w, partnum, mac[w]); @@ -277,6 +276,7 @@ cmd_setmac(void) macf(partnum); cmd_setchecksum(); /* MAC updated; need valid checksum */ + mac_updated = 1; } if (mac_updated)