From aa525142aa872d805d3085819365ce8d51cb93d7 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sat, 23 Dec 2023 08:34:55 +0000 Subject: [PATCH] update/trees: fix infinite loop when make-all is being executed on a coreboot tree, the "./vendor download target" command is used, where target is the tree/board name. that script then checks whether cbfstool and ifdtool are built, and if they're not, they then call ./update trees -b coreboot utils bla bla bla in this scenario, project=coreboot and mode="", meaning make-all, and the same check that checks whether the vendor download script should be run, is executed, which in turn then checks cbutils again fix the infinite loop by checking whether it was coreboot utils, as opposed to *firmware*, that is to be built, before running ./vendor download Signed-off-by: Leah Rowe --- script/update/trees | 1 + 1 file changed, 1 insertion(+) diff --git a/script/update/trees b/script/update/trees index 832f27c5..47b50dd6 100755 --- a/script/update/trees +++ b/script/update/trees @@ -97,6 +97,7 @@ handle_targets() printf "Running 'make %s' for project '%s, target '%s''\n" \ "${mode}" "${project}" "${target}" [ "${project}" != "coreboot" ] || [ -n "${mode}" ] || \ + [ "${target1}" = "utils" ] || \ x_ ./vendor download ${target} x_ handle_defconfig done