From d266d649d836ff9b0e799162e4db390a90db201f Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Sat, 8 Jul 2023 00:35:32 +0100 Subject: [PATCH] safety... build error Signed-off-by: Leah Rowe --- site/docs/build/index.md | 23 +++++++++++++++++++++++ site/docs/build/index.uk.md | 23 +++++++++++++++++++++++ site/news/libreboot20230625.md | 23 +++++++++++++++++++++++ 3 files changed, 69 insertions(+) diff --git a/site/docs/build/index.md b/site/docs/build/index.md index 8be52a3..c0a36d8 100644 --- a/site/docs/build/index.md +++ b/site/docs/build/index.md @@ -298,3 +298,26 @@ under `resources/coreboot/` in the build system. That's it! If all went well, ROM images should be available to you under bin/ + +20230625 build error (release archive) +====================================== + +When building ROM images from the release archives, the following error +is observed in some cases, depending on distro: + +``` +In file included from src/lib/version.c:4: +build/build.h:10:32: error: 'libreboot' undeclared here (not in a function) + 10 | #define COREBOOT_MAJOR_VERSION libreboot-20230625 + | ^~~~~~~~~ +src/lib/version.c:35:46: note: in expansion of macro 'COREBOOT_MAJOR_VERSION' + 35 | const unsigned int coreboot_major_revision = COREBOOT_MAJOR_VERSION; + | ^~~~~~~~~~~~~~~~~~~~~~ +``` + +This happened when a user tried to build for ThinkPad W541 on an Arch Linux +system. The fix is available here: + + + +Apply this patch to your local release archive, and it should fix the issue. diff --git a/site/docs/build/index.uk.md b/site/docs/build/index.uk.md index 7fd1f8d..fa0735f 100644 --- a/site/docs/build/index.uk.md +++ b/site/docs/build/index.uk.md @@ -298,3 +298,26 @@ lbmk. Ось так! Якщо все пройшло добре, образи ROM мають бути доступними вам під bin/ + +20230625 build error (release archive) +====================================== + +When building ROM images from the release archives, the following error +is observed in some cases, depending on distro: + +``` +In file included from src/lib/version.c:4: +build/build.h:10:32: error: 'libreboot' undeclared here (not in a function) + 10 | #define COREBOOT_MAJOR_VERSION libreboot-20230625 + | ^~~~~~~~~ +src/lib/version.c:35:46: note: in expansion of macro 'COREBOOT_MAJOR_VERSION' + 35 | const unsigned int coreboot_major_revision = COREBOOT_MAJOR_VERSION; + | ^~~~~~~~~~~~~~~~~~~~~~ +``` + +This happened when a user tried to build for ThinkPad W541 on an Arch Linux +system. The fix is available here: + + + +Apply this patch to your local release archive, and it should fix the issue. diff --git a/site/news/libreboot20230625.md b/site/news/libreboot20230625.md index 1cada83..442adcb 100644 --- a/site/news/libreboot20230625.md +++ b/site/news/libreboot20230625.md @@ -332,3 +332,26 @@ Downloads You can find this release on the downloads page. At the time of this announcement, some of the rsync mirrors may not have it yet, so please check another one if your favourite one doesn't have it. + +Post-release errata +=================== + +When building ROM images from the release archives, the following error +is observed in some cases, depending on distro: + +``` +In file included from src/lib/version.c:4: +build/build.h:10:32: error: 'libreboot' undeclared here (not in a function) + 10 | #define COREBOOT_MAJOR_VERSION libreboot-20230625 + | ^~~~~~~~~ +src/lib/version.c:35:46: note: in expansion of macro 'COREBOOT_MAJOR_VERSION' + 35 | const unsigned int coreboot_major_revision = COREBOOT_MAJOR_VERSION; + | ^~~~~~~~~~~~~~~~~~~~~~ +``` + +This happened when a user tried to build for ThinkPad W541 on an Arch Linux +system. The fix is available here: + + + +Apply this patch to your local release archive, and it should fix the issue.