Commit Graph

363 Commits (nolan/dark-mode-rebased)

Author SHA1 Message Date
Nolan Lawson f98526a7ed ensure every <li> has a key 2019-03-12 23:15:53 -07:00
Nolan Lawson e3c39bd2fa fix: make each emoji category into a list 2019-03-12 20:56:59 -07:00
Nolan Lawson 585b4b374f fix: improve a11y of skin tone picker 2019-03-12 20:37:45 -07:00
Nolan Lawson 058cdec053 fix: improve accessible page structure
Makes some progress on #294
2019-03-12 09:36:28 -07:00
Nolan Lawson 94404ad339 fix: use tabIndex, not tabindex 2019-03-12 08:39:38 -07:00
Nolan Lawson 978e7b68a1 fix: fix search input when value is prepopulated 2019-03-12 08:21:25 -07:00
Nolan Lawson 5ef7a2a7da
Merge pull request #289 from nolanlawson/nolan/issue-201
fix: fix emoji.id undefined error
2019-03-12 08:20:55 -07:00
Nolan Lawson e3106ac637
Merge pull request #288 from nolanlawson/nolan/remove-notfound-string
fix: remove unused notFoundString prop
2019-03-12 08:20:47 -07:00
Nolan Lawson 27d6a383bd
Merge pull request #287 from nolanlawson/throttle-keyboard-input
perf: throttle keyboard input to improve responsiveness
2019-03-12 08:20:31 -07:00
Nolan Lawson e2694b544b
Merge pull request #285 from nolanlawson/fix-preact-compat-part-2
fix: fix preact compatibility
2019-03-12 08:20:17 -07:00
Nolan Lawson 92c5399ab5
Merge pull request #284 from nolanlawson/issue-218
fix: improve a11y of emoji list
2019-03-12 08:14:54 -07:00
Nolan Lawson 0f35206687 fix: improve a11y of emoji list
fixes #218
2019-03-12 08:14:29 -07:00
Nolan Lawson 740eccb6d0 fix: makes skin tone picker more accessible
fixes #220
2019-03-12 08:12:33 -07:00
Nolan Lawson c2c7092fc4
Merge pull request #282 from nolanlawson/nolan/issue-219
fix: make categories into accessible nav buttons
2019-03-12 08:08:46 -07:00
Nolan Lawson f3cff33eda refactor, add code comment 2019-03-10 10:57:43 -07:00
Nolan Lawson 12c2abba9d fix: fix emoji.id undefined error
fixes #201
2019-03-10 10:47:28 -07:00
Nolan Lawson 13e1dd2e82 fix: remove unused notFoundString prop 2019-03-10 10:40:55 -07:00
Nolan Lawson bd172943d2 fix webkit CSS, fix clear button 2019-03-10 10:35:07 -07:00
Nolan Lawson ef71101cd6 fix prettier 2019-03-10 09:54:12 -07:00
Nolan Lawson 8f6145e383 perf: throttle keyboard input to improve responsiveness 2019-03-10 09:51:47 -07:00
Nolan Lawson 59c4d87839 fix: fix preact compatibility
fixes #254
2019-03-10 09:14:47 -07:00
Nolan Lawson e77c63bc9a fix: make categories into accessible nav buttons
fixes #219
2019-03-09 13:59:09 -08:00
Nolan Lawson b0fee348c0 s/let/const/ 2019-03-09 13:35:48 -08:00
Nolan Lawson 5052ecd399 fix: improve search/clear a11y
fixes #221
2019-03-09 13:03:00 -08:00
Nolan Lawson 28c05b2861 fix: fix babel-runtime not found
fixes #228
2019-03-08 09:00:10 -08:00
Nolan Lawson a871cacbf2
Merge pull request #277 from kayleemann/master
Support case where showPreview is false but showSkinTones is true. Also add prepare script.
2019-03-08 07:32:23 -08:00
Kaylee Mann caba7d0b34 Show preview panel when showPreview is false but showSkinTones is true.
This is necessary in order to be able to show skin tone picker even when
one desires for the mouseover preview to be invisible. This is an
important case because mouseover displays must be disabled in order to
enable single click emoji typing on iOS without disabling the skin tone
picker.
2019-03-08 14:00:50 +09:00
Nolan Lawson c27e62456f
Merge pull request #258 from nolanlawson/remove-proptypes
fix: allow prop-types to be removed in production
2019-03-07 18:18:53 -08:00
Nolan Lawson f60220870e fix: allow prop-types to be removed in production
fixes #257
2019-03-07 18:12:37 -08:00
Nolan Lawson 420e2c7e86
Merge pull request #270 from dwijesingheWR/master
Fixed bug where selecting the first emoji search result with the ENTER KEY ignores skin tone selection
2019-03-07 17:35:22 -08:00
Dimitri Wijesinghe 17db4cc913 Fixed bug where selecting the first emoji search result with the ENTER key ignores skin-tone selection. 2019-02-13 14:56:42 -05:00
Ryann 9b9410e70c forces emoji's not to break line
closes issue #252
2019-01-17 09:25:22 -06:00
kennybll 94baec171d Add sprite support 2018-11-30 09:17:45 -05:00
Peder Johnsen 1c7a5d6ec6 Add `getEmojiDataFromNative` util function to get emoji data from native 2018-11-29 16:08:30 +00:00
Etienne Lemay 7186a10d4f Revert "fix(a11y): ability to tab through different categories"
This reverts commit 937e33534d.
2018-11-14 08:54:13 -05:00
Etienne Lemay 21b3e92bb2
Get rid of components index
Import all components directly, similar to #245
2018-11-13 09:41:57 -05:00
Etienne Lemay a09730d6a8
Merge pull request #226 from hozefaj/master [Close #219]
fix(a11y): ability to tab through different categories
2018-11-13 08:48:59 -05:00
Ross Khanas c0a418fa57
Update category.js 2018-11-13 19:21:37 +09:00
Ross Khanas be27ba5779
Update preview.js 2018-11-13 19:21:07 +09:00
Ross Khanas 9cad93d015
Update nimble-picker.js 2018-11-13 19:19:16 +09:00
hozefaj 937e33534d fix(a11y): ability to tab through different categories 2018-08-25 21:00:48 -07:00
Justine De Caires c6b36947d3 Fixes display of non-52x52 sheets in the preview bar 2018-08-14 22:29:20 -07:00
Etienne Lemay 2c060c56bc
Rename “skinIcon” => “skinEmoji”
More consistent with other props
2018-08-10 14:11:28 -04:00
Etienne Lemay 757f1b023c
Merge branch 'master' into rena/customskin 2018-08-10 14:06:41 -04:00
Etienne Lemay 9b523425c6
💄 2018-08-10 14:02:33 -04:00
Justine De Caires 385cb8f8c2 Add sheetColumns and sheetRows props for non-square sprite sheets 2018-08-06 14:31:02 -07:00
Rena Ryumae f1d5bc0095 Custom emoji for skin tone selector
Currently, the skin tone selector
is a row of colored dots

We propose creating a skinIcon field
that uses the emoji-mart dots on
default but otherwise uses the emoji
passed in by the user
2018-08-02 10:42:46 -04:00
Etienne Lemay 58ceb30d3d
Use ES6 export everywhere in /src 2018-07-31 15:29:11 -04:00
Etienne Lemay 0021d6ff38
Merge branch 'master' into rena/categoryiconprops 2018-07-31 15:01:34 -04:00
Etienne Lemay 2cea3df86a
Call fallback when emoji name isn’t recognized [Fix #199] 2018-07-31 14:05:25 -04:00
Rena Ryumae 31cc0ab215 Customizable Category Icons
Currently, the default emoji-mart
category icons cannot be changed.

We propose creating a categories
object that uses the emoji-mart
category icons on default but
otherwise uses custom imgs/svgs
passed in by the user
2018-07-31 11:09:38 -04:00
Etienne Lemay 767b2fdcc6
Merge pull request #206 from Rena-Ryumae/rena/customnotfound
Not Found Component for emoji search
2018-07-30 17:11:44 -04:00
Etienne Lemay 4bb41b9796
Add notFoundEmoji props to Picker 2018-07-30 17:06:23 -04:00
Etienne Lemay 3dc3e2fd95
Don’t apply `emoji-mart-no-results` class when using custom notFound component 2018-07-30 16:52:15 -04:00
Rena Ryumae 8e6d363d8b Not Found Component for emoji search
If a user's search returns no results,
the sleuth_or_spy emoji appears. We would
instead like for a custom image to appear.

We propose creating a NotFound component
that uses the the sleuth_or_spy emoji
on default when a user's search returns
no results but otherwise uses what the
user passes through
2018-07-13 13:58:17 -04:00
Rena Ryumae 5e03ee3e16 Adding search icon in search input field
Currently, there is no visual indication
for when the user is searching for an
emoji nor is there an easy way to clear
the input field after the user's search

Our change proposes to add a small magnifying
glass icon to the right hand side of the
search input bar which becomes an x delete
icon when the user types in the search input
bar.

The x delete icon is tabbable and will clear
the search input field with the return (enter)
key, spacebar, and mouse click. The
magnifying glass icon is not tabbable.
2018-07-13 13:18:06 -04:00
Etienne Lemay f9d47e9b13
Merge pull request #183 from savardc/missing-on-select-prop
Add missing onSelect to shared props
2018-05-08 08:25:25 -04:00
Etienne Lemay f2b5035f12
Merge pull request #187 from Kovensky/patch-1
Correct NimbleEmojiIndex reexport
2018-05-08 08:25:04 -04:00
Diogo Franco c2f11adec3
Correct NimbleEmojiIndex reexport 2018-05-08 10:59:21 +09:00
Christian Savard 8df31b1c42 Fix typo 2018-05-03 12:40:14 -04:00
Christian Savard 0fff524ed7 Add missing proptype and default value 2018-04-30 10:41:31 -04:00
Etienne Lemay 2e97b1faa6
Restructure data and components 2018-04-29 21:06:32 -04:00
Etienne Lemay 2f5fe6164e
Export NimblePicker, NimbleEmoji and NimbleCategory 2018-04-29 11:41:06 -04:00
Etienne Lemay 0f37b428f6
Rename data.short_names => data.aliases 2018-04-26 16:31:16 -04:00
Etienne Lemay 446fdf9544
Export NimbleEmojiIndex 2018-04-26 15:34:03 -04:00
Etienne Lemay a8b81f1858
Restructure components 2018-04-26 12:10:52 -04:00
Etienne Lemay d17594315c
Make parent Emoji component a functional component
Just like NimbleEmoji.

Read more: https://medium.com/missive-app/45-faster-react-functional-components-now-3509a668e69f
2018-04-26 11:16:21 -04:00
Etienne Lemay 8660a146e2
💄 Prettier 2018-04-26 10:36:54 -04:00
Dave Cilley 892096ea27 Add data property to any components that import data.js, and use that under the hood 2018-03-28 17:30:47 -04:00
Etienne Lemay c113dc5e3b
💄 Add prettier.config.js 2018-03-27 14:52:31 -04:00
Etienne Lemay a71280f14e
Merge pull request #175 from savardc/keyboardSelect
Select first emoji in list with `enter`
2018-03-27 14:45:03 -04:00
Etienne Lemay 4467fbd021
Fix pressing enter when no search results 2018-03-27 14:43:02 -04:00
Etienne Lemay f879348e2e
Fix undefined SEARCH_CATEGORY 2018-03-27 14:41:45 -04:00
Christian Savard 0765bf56f7 Add keyboard selection with enter 2018-03-15 18:42:16 -04:00
vcervellera bf8ffe5413 Clearing custom emojis from index and pool when necessary 2018-03-12 13:35:38 -04:00
Etienne Lemay 88b1045ff7
💄 Prettier 2018-03-02 15:10:04 -05:00
Etienne Lemay c010035015
Add `showSkinTones` prop to Picker [Ref #165] 2018-03-02 15:08:52 -05:00
Etienne Lemay af2fdc71a1
Add `defaultSkin` prop to Picker and allow forcing skin tone with `skin` prop [Ref #165] 2018-03-02 13:45:33 -05:00
Etienne Lemay b0753769fb
Add `onSkinChange` prop to Picker [Close #165] 2018-03-02 13:33:14 -05:00
Etienne Lemay fed9a89c78
Set RECENT_CATEGORY, CUSTOM_CATEGORY and SEARCH_CATEGORY on Picker instances [Fix #166] 2018-03-02 13:25:39 -05:00
vcervellera 88d7e2f506 Emptying custom category when custom prop is cleared 2018-02-22 09:58:10 -05:00
syokenz 6e4dd6765c change to return -1 in Categories sort compareFunction 2018-02-15 22:39:17 +09:00
Etienne Lemay e5441d637e
Merge pull request #159 from scttcper/master
remove unused name
2018-01-15 17:03:42 -05:00
Scott Cooper 8e83059f58 remove unused name 2018-01-10 22:41:50 -08:00
Andrew Beaven 238b2d2ff2 Remove Emoji fallback defaultProp 2018-01-11 10:45:02 +13:00
Andrew Beaven 4008363e73 Don't render fallback inside an emoji `<span>` 2018-01-10 11:38:30 +13:00
Andrew Beaven 818b4a1600 Emoji fallback shouldn't apply styling #157 2018-01-10 11:24:51 +13:00
Etienne Lemay 68a4711658 💄 2018-01-09 15:20:18 -05:00
Etienne Lemay 6d095a072c Add `html` props to Emoji component [Ref #79] 2018-01-09 15:16:59 -05:00
Etienne Lemay 3fa0331d60 Support providing a fallback to unsupported emojis [Fix #157] 2018-01-09 15:16:59 -05:00
Etienne Lemay d17c8a5c4b
Merge pull request #153 from savardc/fix-search-with-custom
Fix search with custom data and filter
2018-01-09 15:16:26 -05:00
Mark Wadden 3c924a1619 Bug fix to ensure that the category ids are not dropped aftering being filtered. 2017-12-21 22:24:36 -05:00
Christian Savard b644e3d2d3 Use pool to lookup emoji data 2017-12-20 11:33:15 -05:00
Etienne Lemay e78609b5c0 💄 2017-12-15 15:31:49 -05:00
Etienne Lemay 1119d60b6e Use categories id in SVGs 2017-12-15 15:30:58 -05:00
Etienne Lemay 8f63c38308 Use 256-color indexed sheets by default
Reduces sheets size by half
2017-12-15 15:23:15 -05:00
Etienne Lemay e4977e4f0d Update emoji-datasource to 4.0.2 2017-12-15 15:12:50 -05:00
Etienne Lemay 453f723d5e Fix include / exclude [Fix #149]
Since fdf3c2d
2017-12-15 15:09:46 -05:00
Etienne Lemay 992cd65e81 Sheets now have 51 columns
Since emoji-datasource 4.0.0
2017-12-08 13:37:35 -05:00
Etienne Lemay fdf3c2d3a3 Fix getting category names from i18n
Since the Category names update in emoji-data (4.0.0)
2017-12-08 12:45:31 -05:00