Commit Graph

130 Commits (nolan/no-underscore-json)

Author SHA1 Message Date
Nolan Lawson 3a4dc78185 fix: remove _JSON 2019-12-21 09:59:03 -08:00
Xavier Shay 956aaa91f3 fix: Deterministic sorting of search results. (#343)
* Deterministic sorting of search results.

This is important for reliable tests, e.g. if you are snapshotting views
and comparing to reference images.

* fix prettier
2019-06-29 07:53:46 -07:00
Etienne Lemay 4fda4dcc01 fix: use span for non-clickable emojis 2019-03-28 08:59:19 -04:00
Etienne Lemay cbad12426c
Merge pull request #317 from nolanlawson/nolan/308-addendum
fix: consistently return short_names from sanitize
2019-03-28 07:37:39 -04:00
Peder Johnsen ab2f6004ac Add tests 2019-03-23 21:31:11 +00:00
Peder Johnsen 5570a7ce1a Run prettier 2019-03-23 21:15:47 +00:00
Peder Johnsen 5c64cc6908 Use for loop and refactor lookup code 2019-03-23 21:14:52 +00:00
Peder Johnsen 90b36d829f Get skinToneIndex from forEach function 2019-03-23 21:13:02 +00:00
Peder Johnsen 0ab34e20a3 Remove empty strings from skinTones and skinCodes. 2019-03-23 21:12:40 +00:00
Peder Johnsen a8c491273c Merge remote-tracking branch 'emojimart/master' into get_emoji_data_from_native 2019-03-23 20:35:16 +00:00
Peder Johnsen dce30b3f09 Fix typo 2019-03-23 16:39:40 +00:00
Nolan Lawson 3c0c0caffc fix: fix prettier 2019-03-23 09:18:50 -07:00
Peder Johnsen ed241d1d42 Revert skin tone emoji on search code 2019-03-23 15:34:46 +00:00
Peder Johnsen e00371c86e Keep new line 2019-03-23 15:20:21 +00:00
Peder Johnsen b76be74e96 Add test 2019-03-23 15:18:26 +00:00
Peder Johnsen 51a0879ec1 Return emojis with skin tone from store on nimble search 2019-03-23 15:17:37 +00:00
Nolan Lawson fa7141653d fix: consistently return short_names from sanitize 2019-03-22 15:59:55 -07:00
Peder Johnsen f760c55440 Return skin emojis in search. Refactor getEmojiDataFromNative 2019-03-20 11:25:48 +00:00
Peder Johnsen 22a5ca587f Merge branch 'emojimart' into get_emoji_data_from_native 2019-03-20 09:08:32 +00:00
hina a1a12abcd5 keep short_names on sanitize 2019-03-19 05:10:40 +09:00
Etienne Lemay dce1244b8a
Don’t set custom emojis `imageUrl` required
+ add missing prop types since #251
2019-03-14 20:47:38 -04:00
Nolan Lawson 9b6676a25d
Merge pull request #302 from nolanlawson/nolan/jest-tests
test: replace karma with jest
2019-03-14 08:34:03 -07:00
Nolan Lawson 302663f8bf test: replace karma with jest 2019-03-13 20:04:52 -07:00
Nolan Lawson d1978c096f fix: improve requestIdleCallback usage 2019-03-13 08:54:40 -07:00
Nolan Lawson 8f6145e383 perf: throttle keyboard input to improve responsiveness 2019-03-10 09:51:47 -07:00
Nolan Lawson f60220870e fix: allow prop-types to be removed in production
fixes #257
2019-03-07 18:12:37 -08:00
Peder Johnsen 1c7a5d6ec6 Add `getEmojiDataFromNative` util function to get emoji data from native 2018-11-29 16:08:30 +00:00
Etienne Lemay 2c060c56bc
Rename “skinIcon” => “skinEmoji”
More consistent with other props
2018-08-10 14:11:28 -04:00
Etienne Lemay 757f1b023c
Merge branch 'master' into rena/customskin 2018-08-10 14:06:41 -04:00
Justine De Caires 385cb8f8c2 Add sheetColumns and sheetRows props for non-square sprite sheets 2018-08-06 14:31:02 -07:00
Rena Ryumae f1d5bc0095 Custom emoji for skin tone selector
Currently, the skin tone selector
is a row of colored dots

We propose creating a skinIcon field
that uses the emoji-mart dots on
default but otherwise uses the emoji
passed in by the user
2018-08-02 10:42:46 -04:00
Etienne Lemay 58ceb30d3d
Use ES6 export everywhere in /src 2018-07-31 15:29:11 -04:00
Etienne Lemay 0021d6ff38
Merge branch 'master' into rena/categoryiconprops 2018-07-31 15:01:34 -04:00
Rena Ryumae 31cc0ab215 Customizable Category Icons
Currently, the default emoji-mart
category icons cannot be changed.

We propose creating a categories
object that uses the emoji-mart
category icons on default but
otherwise uses custom imgs/svgs
passed in by the user
2018-07-31 11:09:38 -04:00
Etienne Lemay 4bb41b9796
Add notFoundEmoji props to Picker 2018-07-30 17:06:23 -04:00
Rena Ryumae 8e6d363d8b Not Found Component for emoji search
If a user's search returns no results,
the sleuth_or_spy emoji appears. We would
instead like for a custom image to appear.

We propose creating a NotFound component
that uses the the sleuth_or_spy emoji
on default when a user's search returns
no results but otherwise uses what the
user passes through
2018-07-13 13:58:17 -04:00
Etienne Lemay f9d47e9b13
Merge pull request #183 from savardc/missing-on-select-prop
Add missing onSelect to shared props
2018-05-08 08:25:25 -04:00
Christian Savard 8df31b1c42 Fix typo 2018-05-03 12:40:14 -04:00
Christian Savard 0fff524ed7 Add missing proptype and default value 2018-04-30 10:41:31 -04:00
Etienne Lemay 2e97b1faa6
Restructure data and components 2018-04-29 21:06:32 -04:00
Etienne Lemay 0f37b428f6
Rename data.short_names => data.aliases 2018-04-26 16:31:16 -04:00
Etienne Lemay 446fdf9544
Export NimbleEmojiIndex 2018-04-26 15:34:03 -04:00
Etienne Lemay 8660a146e2
💄 Prettier 2018-04-26 10:36:54 -04:00
Dave Cilley 892096ea27 Add data property to any components that import data.js, and use that under the hood 2018-03-28 17:30:47 -04:00
Etienne Lemay c113dc5e3b
💄 Add prettier.config.js 2018-03-27 14:52:31 -04:00
vcervellera bf8ffe5413 Clearing custom emojis from index and pool when necessary 2018-03-12 13:35:38 -04:00
Etienne Lemay 68a4711658 💄 2018-01-09 15:20:18 -05:00
Christian Savard b644e3d2d3 Use pool to lookup emoji data 2017-12-20 11:33:15 -05:00
Etienne Lemay e78609b5c0 💄 2017-12-15 15:31:49 -05:00
Etienne Lemay 453f723d5e Fix include / exclude [Fix #149]
Since fdf3c2d
2017-12-15 15:09:46 -05:00