From 116b8a63633cfdff83582f1cc40559c2e3c2ae80 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Thu, 17 Aug 2017 22:15:37 +0200 Subject: [PATCH] Fix #4607 - Accept/reject activities use FollowRequest, which has inverse relations (#4616) --- .../activitypub/accept_follow_serializer.rb | 2 +- .../activitypub/inverse_follow_serializer.rb | 22 +++++++++++++++++++ .../activitypub/reject_follow_serializer.rb | 2 +- 3 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 app/serializers/activitypub/inverse_follow_serializer.rb diff --git a/app/serializers/activitypub/accept_follow_serializer.rb b/app/serializers/activitypub/accept_follow_serializer.rb index 3e23591a52..f1c9d90238 100644 --- a/app/serializers/activitypub/accept_follow_serializer.rb +++ b/app/serializers/activitypub/accept_follow_serializer.rb @@ -3,7 +3,7 @@ class ActivityPub::AcceptFollowSerializer < ActiveModel::Serializer attributes :id, :type, :actor - has_one :object, serializer: ActivityPub::FollowSerializer + has_one :object, serializer: ActivityPub::InverseFollowSerializer def id [ActivityPub::TagManager.instance.uri_for(object.target_account), '#accepts/follows/', object.id].join diff --git a/app/serializers/activitypub/inverse_follow_serializer.rb b/app/serializers/activitypub/inverse_follow_serializer.rb new file mode 100644 index 0000000000..58e0eaad0b --- /dev/null +++ b/app/serializers/activitypub/inverse_follow_serializer.rb @@ -0,0 +1,22 @@ +# frozen_string_literal: true + +class ActivityPub::InverseFollowSerializer < ActiveModel::Serializer + attributes :id, :type, :actor + attribute :virtual_object, key: :object + + def id + [ActivityPub::TagManager.instance.uri_for(object.target_account), '#follows/', object.id].join + end + + def type + 'Follow' + end + + def actor + ActivityPub::TagManager.instance.uri_for(object.target_account) + end + + def virtual_object + ActivityPub::TagManager.instance.uri_for(object.account) + end +end diff --git a/app/serializers/activitypub/reject_follow_serializer.rb b/app/serializers/activitypub/reject_follow_serializer.rb index 7814f4f575..9a98229143 100644 --- a/app/serializers/activitypub/reject_follow_serializer.rb +++ b/app/serializers/activitypub/reject_follow_serializer.rb @@ -3,7 +3,7 @@ class ActivityPub::RejectFollowSerializer < ActiveModel::Serializer attributes :id, :type, :actor - has_one :object, serializer: ActivityPub::FollowSerializer + has_one :object, serializer: ActivityPub::InverseFollowSerializer def id [ActivityPub::TagManager.instance.uri_for(object.target_account), '#rejects/follows/', object.id].join