From 5b457961fc1189a71599dc6c06b3f159b195a455 Mon Sep 17 00:00:00 2001
From: Claire <claire.github-309c@sitedethib.com>
Date: Fri, 21 Jul 2023 14:21:10 +0200
Subject: [PATCH] Fix linting issue (#26106)

---
 spec/lib/vacuum/applications_vacuum_spec.rb | 30 ++++++++++-----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/spec/lib/vacuum/applications_vacuum_spec.rb b/spec/lib/vacuum/applications_vacuum_spec.rb
index d30311ab13..57a222aafc 100644
--- a/spec/lib/vacuum/applications_vacuum_spec.rb
+++ b/spec/lib/vacuum/applications_vacuum_spec.rb
@@ -6,43 +6,43 @@ RSpec.describe Vacuum::ApplicationsVacuum do
   subject { described_class.new }
 
   describe '#perform' do
-    let!(:app1) { Fabricate(:application, created_at: 1.month.ago) }
-    let!(:app2) { Fabricate(:application, created_at: 1.month.ago) }
-    let!(:app3) { Fabricate(:application, created_at: 1.month.ago) }
-    let!(:app4) { Fabricate(:application, created_at: 1.month.ago, owner: Fabricate(:user)) }
-    let!(:app5) { Fabricate(:application, created_at: 1.month.ago) }
-    let!(:app6) { Fabricate(:application, created_at: 1.hour.ago) }
+    let!(:app_with_token)  { Fabricate(:application, created_at: 1.month.ago) }
+    let!(:app_with_grant)  { Fabricate(:application, created_at: 1.month.ago) }
+    let!(:app_with_signup) { Fabricate(:application, created_at: 1.month.ago) }
+    let!(:app_with_owner)  { Fabricate(:application, created_at: 1.month.ago, owner: Fabricate(:user)) }
+    let!(:unused_app)      { Fabricate(:application, created_at: 1.month.ago) }
+    let!(:recent_app)      { Fabricate(:application, created_at: 1.hour.ago) }
 
-    let!(:active_access_token) { Fabricate(:access_token, application: app1) }
-    let!(:active_access_grant) { Fabricate(:access_grant, application: app2) }
-    let!(:user) { Fabricate(:user, created_by_application: app3) }
+    let!(:active_access_token) { Fabricate(:access_token, application: app_with_token) }
+    let!(:active_access_grant) { Fabricate(:access_grant, application: app_with_grant) }
+    let!(:user) { Fabricate(:user, created_by_application: app_with_signup) }
 
     before do
       subject.perform
     end
 
     it 'does not delete applications with valid access tokens' do
-      expect { app1.reload }.to_not raise_error
+      expect { app_with_token.reload }.to_not raise_error
     end
 
     it 'does not delete applications with valid access grants' do
-      expect { app2.reload }.to_not raise_error
+      expect { app_with_grant.reload }.to_not raise_error
     end
 
     it 'does not delete applications that were used to create users' do
-      expect { app3.reload }.to_not raise_error
+      expect { app_with_signup.reload }.to_not raise_error
     end
 
     it 'does not delete owned applications' do
-      expect { app4.reload }.to_not raise_error
+      expect { app_with_owner.reload }.to_not raise_error
     end
 
     it 'does not delete applications registered less than a day ago' do
-      expect { app6.reload }.to_not raise_error
+      expect { recent_app.reload }.to_not raise_error
     end
 
     it 'deletes unused applications' do
-      expect { app5.reload }.to raise_error ActiveRecord::RecordNotFound
+      expect { unused_app.reload }.to raise_error ActiveRecord::RecordNotFound
     end
   end
 end