Move filtered notifications bar in scrollable area (#30996)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
pull/2777/head
David Roetzel 2024-07-15 15:42:47 +02:00 committed by GitHub
parent 0b97ec3f7b
commit 9d0bce4072
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 5 deletions

View File

@ -223,6 +223,13 @@ class Notifications extends PureComponent {
let scrollContainer;
const prepend = (
<>
{needsNotificationPermission && <NotificationsPermissionBanner />}
<FilteredNotificationsBanner />
</>
);
if (signedIn) {
scrollContainer = (
<ScrollableList
@ -232,7 +239,7 @@ class Notifications extends PureComponent {
showLoading={isLoading && notifications.size === 0}
hasMore={hasMore}
numPending={numPending}
prepend={needsNotificationPermission && <NotificationsPermissionBanner />}
prepend={prepend}
alwaysPrepend
emptyMessage={emptyMessage}
onLoadMore={this.handleLoadOlder}
@ -282,8 +289,6 @@ class Notifications extends PureComponent {
{filterBarContainer}
<FilteredNotificationsBanner />
{scrollContainer}
<Helmet>

View File

@ -10192,8 +10192,7 @@ noscript {
.filtered-notifications-banner {
display: flex;
align-items: center;
border: 1px solid var(--background-border-color);
border-top: 0;
border-bottom: 1px solid var(--background-border-color);
padding: 24px 32px;
gap: 16px;
color: $darker-text-color;