Add coverage/bugfix for invalid appeal submission (#28703)

pull/2573/head
Matt Jankowski 2024-01-12 04:21:00 -05:00 committed by GitHub
parent 7801db7ba4
commit a90696011e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 10 deletions

View File

@ -21,7 +21,7 @@
.report-header
.report-header__card
= render 'card', strike: @strike
= render 'disputes/strikes/card', strike: @strike
.report-header__details
.report-header__details__item

View File

@ -10,19 +10,38 @@ RSpec.describe Disputes::AppealsController do
let!(:admin) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
describe '#create' do
let(:current_user) { Fabricate(:user) }
let(:strike) { Fabricate(:account_warning, target_account: current_user.account) }
context 'with valid params' do
let(:current_user) { Fabricate(:user) }
let(:strike) { Fabricate(:account_warning, target_account: current_user.account) }
before do
post :create, params: { strike_id: strike.id, appeal: { text: 'Foo' } }
before do
post :create, params: { strike_id: strike.id, appeal: { text: 'Foo' } }
end
it 'notifies staff about new appeal', :sidekiq_inline do
expect(ActionMailer::Base.deliveries.first.to).to eq([admin.email])
end
it 'redirects back to the strike page' do
expect(response).to redirect_to(disputes_strike_path(strike.id))
end
end
it 'notifies staff about new appeal', :sidekiq_inline do
expect(ActionMailer::Base.deliveries.first.to).to eq([admin.email])
end
context 'with invalid params' do
let(:current_user) { Fabricate(:user) }
let(:strike) { Fabricate(:account_warning, target_account: current_user.account) }
it 'redirects back to the strike page' do
expect(response).to redirect_to(disputes_strike_path(strike.id))
before do
post :create, params: { strike_id: strike.id, appeal: { text: '' } }
end
it 'does not send email', :sidekiq_inline do
expect(ActionMailer::Base.deliveries.size).to eq(0)
end
it 'renders the strike show page' do
expect(response).to render_template('disputes/strikes/show')
end
end
end
end