Merge pull request #479 from ThibG/glitch-soc/fixes/modal-root-keyup
Fix root modal's keyup handling (Fixes #478)pull/481/head
commit
bd4decb7db
|
@ -6,6 +6,7 @@ export default class ModalRoot extends React.PureComponent {
|
|||
static propTypes = {
|
||||
children: PropTypes.node,
|
||||
onClose: PropTypes.func.isRequired,
|
||||
noEsc: PropTypes.bool,
|
||||
};
|
||||
|
||||
state = {
|
||||
|
@ -16,7 +17,7 @@ export default class ModalRoot extends React.PureComponent {
|
|||
|
||||
handleKeyUp = (e) => {
|
||||
if ((e.key === 'Escape' || e.key === 'Esc' || e.keyCode === 27)
|
||||
&& !!this.props.children && !this.props.props.noEsc) {
|
||||
&& !!this.props.children && !this.props.noEsc) {
|
||||
this.props.onClose();
|
||||
}
|
||||
}
|
||||
|
|
|
@ -59,7 +59,7 @@ export default class ModalRoot extends React.PureComponent {
|
|||
const visible = !!type;
|
||||
|
||||
return (
|
||||
<Base onClose={onClose}>
|
||||
<Base onClose={onClose} noEsc={props.noEsc}>
|
||||
{visible && (
|
||||
<BundleContainer fetchComponent={MODAL_COMPONENTS[type]} loading={this.renderLoading(type)} error={this.renderError} renderDelay={200}>
|
||||
{(SpecificComponent) => <SpecificComponent {...props} onClose={onClose} />}
|
||||
|
|
Loading…
Reference in New Issue