1e7d5d2957
Update `devise-two-factor` to version 5.0.0 ( #28325 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-05-02 09:31:41 +00:00
2447497a4c
Status length validation spec updates ( #30132 )
2024-05-02 08:31:06 +00:00
91ca90e25b
Fix Idempotency-Key ignored when scheduling a post ( #30084 )
2024-04-26 13:19:02 +00:00
e845594878
Fix moderator account being exposed in account moderation notification ( #30082 )
2024-04-26 12:42:06 +00:00
4ef0b48b95
Add in-app notifications for moderation actions/warnings ( #30065 )
2024-04-25 17:26:05 +00:00
049b159beb
Add read:me OAuth 2.0 scope, allowing more limited access to user data ( #29087 )
2024-04-23 11:47:00 +00:00
a15139bc02
Fix intermittent order based failure in `UpdateStatusService` spec ( #30008 )
2024-04-22 08:30:38 +00:00
f5d341382e
Add `any_args` to have_enqueued_sidekiq_job call (quiets deprecation) ( #29999 )
2024-04-19 19:44:59 +00:00
11e0049b08
Use enum-generated scopes/queries for `BulkImport` ( #29975 )
2024-04-18 10:13:35 +00:00
8bece467f8
Change `have_enqueued_sidekiq_job` usage to always make argument expectations explicit ( #29974 )
2024-04-17 11:13:52 +00:00
650c548c31
Add `not_featured_by` scope to Tag ( #28815 )
2024-04-17 10:05:38 +00:00
9ce2db4136
Combine double subject runs and DRY up change check in bulk import service spec ( #29402 )
2024-04-17 08:23:25 +00:00
6fed108703
Use Rails `upsert` to generate update_count! query in Counters concern ( #28738 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-04-17 08:16:51 +00:00
7fed4a9740
Pull out repeated setup to shared setup in statusus/show view spec ( #29927 )
2024-04-15 15:24:31 +00:00
61d108f415
Extract `header_tags` method in statuses/show view spec ( #29907 )
2024-04-12 09:50:46 +00:00
da6b9238f5
Expand coverage for admin/metrics/measure/* classes ( #29914 )
2024-04-12 09:38:24 +00:00
ec5a0e0f5e
Expand coverage for admin/metrics/dimension/* classes ( #29913 )
2024-04-12 09:18:35 +00:00
449f99e168
Fix repeated concat output buffer duplicating layout markup ( #29918 )
2024-04-11 23:37:07 +00:00
576554b19b
Use fabrication sequence in domain values ( #29895 )
2024-04-11 08:59:01 +00:00
285f63c02e
Use composable query in `User.active` scope ( #29775 )
2024-04-08 13:53:49 +00:00
babbf6017d
Remove caching in `cache_collection` ( #29862 )
2024-04-08 13:46:13 +00:00
e73cf356d2
Move OAuth flow tests from feature tests to system tests ( #29837 )
2024-04-05 16:52:05 +00:00
b61ae28f8d
Separate methods for theme style and meta color tags ( #29802 )
2024-04-05 09:52:43 +00:00
59da591d13
Improve spec for dimension/languages admin metric ( #29842 )
2024-04-05 08:54:11 +00:00
38b9d31f63
Improve email address validation ( #29838 )
2024-04-05 07:48:45 +00:00
1f11aa5f04
Add stub for trending tags in user mailer spec ( #29850 )
2024-04-05 07:48:07 +00:00
191bf5876e
Add coverage for sanitize failure path in api/web/embeds spec ( #29851 )
2024-04-04 16:07:16 +00:00
f87959ab50
Fix `RSpec/LetSetup` cop in api/v1/timelines/public spec ( #28972 )
2024-04-02 14:05:02 +00:00
34489591ec
Add `max_pinned_statuses` to instances serializer and api response ( #29441 )
2024-04-02 13:54:11 +00:00
b4d991adaa
Use integers and not numbers in notification policy API counters ( #29810 )
2024-04-02 10:06:26 +00:00
589e34d00c
Update dependency selenium-webdriver to v4.19.0 ( #29776 )
...
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-04-02 08:53:44 +00:00
9c24f2d6b1
Undo notification permissions on individual and domain blocks ( #29570 )
2024-03-26 14:46:38 +00:00
81a04ac25c
Improve specs for severed relationships ( #29688 )
2024-03-22 16:25:36 +00:00
34f293475e
Fix results/query in `api/v1/featured_tags/suggestions` ( #29597 )
2024-03-22 15:08:27 +00:00
05eda8d193
Remove severed relationship notifications for single account suspensions ( #29700 )
2024-03-21 21:53:24 +00:00
814a48517f
Add some more tests for notification policies ( #29698 )
2024-03-21 16:46:38 +00:00
7434c9c276
Fix the relationships controller spec, since it requires an extra model now ( #29671 )
2024-03-21 08:28:37 +00:00
44bf7b8128
Add notifications of severed relationships ( #27511 )
2024-03-20 15:37:21 +00:00
8a1423a474
Allow unblocking email addresses from any matching account ( #29305 )
2024-03-20 14:38:00 +00:00
6d2986017e
Remove unused `active_nav_class` helper method ( #29617 )
2024-03-18 13:24:59 +00:00
d5063072c3
Revert friends-of-friends follow recommendation query to using a CTE ( #29619 )
2024-03-18 12:57:21 +00:00
92855948a0
Remove unused `show_landing_strip?` helper method ( #29618 )
2024-03-18 08:55:54 +00:00
ecdbf15ebe
Remove unused `link_to_older` and `link_to_newer` helper methods ( #29620 )
2024-03-18 08:54:46 +00:00
4f4132f1a1
Add diagnostic message for failure during CLI search deploy ( #29462 )
2024-03-15 14:26:23 +00:00
2e91a9bd34
Add `include_pagination_headers` matcher to check `Link` header in api specs ( #29596 )
2024-03-15 10:17:45 +00:00
e75b55a6d7
Extract target account on list method in bulk import row service spec ( #29601 )
2024-03-15 09:31:25 +00:00
974c7672e5
Extract shared behavior methods in oauth feature spec ( #28360 )
2024-03-14 13:42:59 +00:00
0bc17a3d48
Use enum-generated `public_visibility` scope on Status ( #28156 )
2024-03-14 09:31:57 +00:00
681a89f684
Readability clean up in `ImportVacuum` spec ( #28955 )
2024-03-14 09:24:00 +00:00
f9100743ec
Add `Api::ErrorHandling` concern for api/base controller ( #29574 )
2024-03-14 09:09:47 +00:00
42875fee52
Add coverage for bad args/options in `CLI::Domains#purge` ( #29578 )
2024-03-14 08:58:53 +00:00
71e5f0f48c
Add coverage for suspended instance actor scenario ( #29571 )
2024-03-13 15:43:40 +00:00
6262ceeb70
Fix `RSpec/DescribedClass` cop ( #29472 )
2024-03-13 15:42:39 +00:00
c09b8a7164
Add `Account.without_internal` scope ( #29559 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-03-13 14:11:23 +00:00
46e902f1f3
Merge `api/v1/accounts/credentials` controller spec into existing request spec ( #29006 )
2024-03-13 09:22:43 +00:00
01b624c4a0
Use `normalizes` on `CustomFilter#context` value ( #27602 )
2024-03-13 08:50:21 +00:00
71eecbfa1f
Move `api/v2/filters/*` to request spec ( #28956 )
2024-03-13 08:47:09 +00:00
8349b45d60
Accept extra args that we wont verify in `ap/activity/add_spec` ( #29005 )
2024-03-13 08:46:11 +00:00
469028b6d3
Remove unneeded `type: :service` from spec/services files ( #29304 )
2024-03-13 08:39:26 +00:00
3eaac3af73
Use `before_all` block to setup `requests/cache_spec` data ( #29437 )
2024-03-13 08:38:57 +00:00
19f0590795
Add basic coverage for `TagSearchService` class ( #29319 )
2024-03-13 08:33:03 +00:00
96013cd576
Reduce `RSpec/ExampleLength` in CSP request spec ( #29104 )
2024-03-13 08:22:32 +00:00
216cea1e27
Fix incorrect frequency value in `FriendsOfFriendsSource` data ( #29550 )
2024-03-12 08:38:32 +00:00
24319836de
Convert request-based setup into factory setup in push/subscriptions request spec ( #29489 )
2024-03-11 15:46:25 +00:00
a38e424185
Use unchanging github links in docs/comments ( #29545 )
2024-03-11 15:14:55 +00:00
c10bbf5fe3
Add notification policies and notification requests in web UI ( #29433 )
2024-03-11 15:02:21 +00:00
4a6ddbc9c0
Normalize idna domain before account unblock domain ( #29530 )
2024-03-11 09:28:08 +00:00
a7284690fc
Add coverage for admin/metrics base classes, simplify subclass generation ( #29527 )
2024-03-11 09:16:19 +00:00
98ef38e34e
Ensure unique values in fabricators ( #29515 )
2024-03-11 08:53:24 +00:00
50b17f7e10
Add notification policies and notification requests ( #29366 )
2024-03-07 14:53:37 +00:00
ee8d0b9447
Fix follow suggestions potentially including silenced or blocked accounts ( #29306 )
2024-03-04 06:35:20 +00:00
18945f62e0
Convert more API specs from controller->request style ( #29004 )
2024-03-01 16:24:45 +00:00
a25014de8f
Improve `IpBlock` model test coverage ( #29460 )
2024-03-01 16:17:40 +00:00
3389c41b58
Move `nobody` position in `UserRole` magic number to constant ( #29465 )
2024-03-01 11:05:24 +00:00
eb1b8f69de
Allow pagination `Link` headers on API accounts/statuses when pinned true ( #29442 )
2024-02-29 14:21:56 +00:00
6675bf574a
Extract `parsed_uri_query_values` helper in ap/replies controller spec ( #29410 )
2024-02-29 13:47:38 +00:00
14c65180df
Use sequence in `software_update` fabricator to allow multiple ( #29438 )
2024-02-29 10:51:11 +00:00
8f3c91fc3c
Add `change` block expectation to `admin/invites#deactivate_all` spec ( #29412 )
2024-02-27 16:25:58 +00:00
6f7615ba86
Add basic end-to-end test for admin moderation interface ( #29424 )
2024-02-27 15:18:06 +00:00
9e78129e6e
Use "cacheable response" shared example in more places ( #29419 )
2024-02-27 11:50:21 +00:00
8156113d58
Use `response_vary_headers` method in requests/cache_spec ( #29411 )
2024-02-26 16:27:07 +00:00
1540f42522
Better tests for auth/registrations#update ( #29303 )
2024-02-26 16:09:56 +00:00
d51c3ac087
Add a missing spec to `SessionsController#webauthn_options` ( #29277 )
2024-02-26 16:09:40 +00:00
b0064ddda7
Add basic coverage for `MoveService` class ( #29301 )
2024-02-23 09:59:29 +00:00
a6ed148769
Use heredoc on the `HTML` blocks in verify link spec ( #29365 )
2024-02-22 21:26:48 +00:00
9d8dfeb5fb
Fix processing of `Link` objects in `Image` objects ( #29335 )
2024-02-22 22:27:24 +01:00
5152dd869e
Fix link verifications when page size exceeds 1MB ( #29358 )
2024-02-22 17:31:50 +00:00
b71904816a
Change registrations to be disabled by default for new servers ( #29280 )
2024-02-22 13:28:19 +00:00
e9b0f0c314
Add basic coverage for `RemoveDomainsFromFollowersService` class ( #29327 )
2024-02-22 10:53:38 +00:00
7c7dfe7de3
Add basic coverage for `RemoveFeaturedTagService` class ( #29328 )
2024-02-22 10:51:04 +00:00
6342ddd698
Add basic coverage for `UnfavouriteService` class ( #29329 )
2024-02-22 10:48:42 +00:00
f70905f127
Add basic coverage for `UnmuteService` class ( #29330 )
2024-02-22 10:48:09 +00:00
a69fe534e3
Add basic coverage for `WebhookService` class ( #29331 )
2024-02-22 10:46:20 +00:00
d1602c017d
Add basic coverage for `ApproveAppealService` class ( #29333 )
2024-02-22 10:40:07 +00:00
ab2ef63a03
Add basic coverage for `VoteService` class ( #29334 )
2024-02-22 10:39:18 +00:00
2751acb6cd
Automatically switch from open to approved registrations in absence of moderators ( #29318 )
2024-02-21 17:45:06 +00:00
08342ad40c
Add basic coverage for `AfterUnallowDomainService` class ( #29324 )
2024-02-21 17:13:11 +00:00
8f61e32569
Add basic coverage for `AppealService` class ( #29322 )
2024-02-21 17:12:31 +00:00
b73932461f
Add basic coverage for `CreateFeaturedTagService` class ( #29321 )
2024-02-21 16:58:19 +00:00
5f19e7e799
Add basic coverage for `ProcessHashtagsService` class ( #29320 )
2024-02-21 16:57:45 +00:00
1f648fdf1a
Remove erroneous service type on `TagFeed` model spec ( #29302 )
2024-02-21 11:25:33 +00:00
64f9939e39
Use `capture_emails` helper to improve email assertions in specs ( #29245 )
2024-02-19 15:57:47 +00:00
86627ea2e4
Add a missing thread example to the statuses spec ( #29278 )
2024-02-19 13:35:58 +00:00
245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants ( #29260 )
2024-02-19 11:09:43 +00:00
96ddf1d482
Fix flaky end-to-end OCR test ( #29244 )
2024-02-16 16:57:23 +00:00
1946e171e6
Reduce round trips in admin/disputes/appeals spec ( #29234 )
2024-02-16 13:46:28 +00:00
3454fcbd71
Reduce round trips in auth/sessions spec ( #29233 )
2024-02-16 13:38:49 +00:00
a316c0e38d
Reduce round trips in disputes/appeals spec ( #29232 )
2024-02-16 13:01:15 +00:00
117b507df5
Extract `subject` from `User#mark_email_as_confirmed!` spec ( #29231 )
2024-02-16 13:01:04 +00:00
1690fb39e6
Reduce `RSpec/MultipleExpectations` in instance_actors_controller spec ( #29229 )
2024-02-16 13:00:11 +00:00
bba488c189
Reduce `RSpec/MultipleExpectations` in media_attachment spec ( #29228 )
2024-02-16 13:00:09 +00:00
9fee5e8526
Merge pull request from GHSA-jhrq-qvrm-qr36
...
* Fix insufficient Content-Type checking of fetched ActivityStreams objects
* Allow JSON-LD documents with multiple profiles
2024-02-16 11:56:12 +01:00
a9f9b0097b
Reduce `RSpec/MultipleExpectations` in captcha feature spec ( #29226 )
2024-02-16 07:52:57 +00:00
4b7f04e3ea
Reduce `RSpec/MultipleExpectations` in post_status_service spec ( #29225 )
2024-02-16 07:52:29 +00:00
ed4939296a
Reduce `RSpec/MultipleExpectations` in ap/activity/create spec ( #29224 )
2024-02-16 07:43:00 +00:00
1df2ffc3ee
Use `subject` in blacklist email validator spec ( #29211 )
2024-02-16 07:42:03 +00:00
fc4f823464
Avoid local block var assignment in ap/process_status_update_service spec ( #29210 )
2024-02-16 07:41:25 +00:00
d4d0565b0f
Fix user creation failure handling in OAuth paths ( #29207 )
2024-02-14 21:49:45 +00:00
bbbbf00084
Fix OmniAuth tests ( #29201 )
2024-02-14 14:57:49 +00:00
b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
...
* Prevent different identities from a same SSO provider from accessing a same account
* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`
* Rename methods to avoid confusion between OAuth and OmniAuth
2024-02-14 15:16:07 +01:00
68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
...
* Ensure destruction of OAuth Applications notifies streaming
Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.
* Ensure password resets revoke access to Streaming API
* Improve performance of deleting OAuth tokens
---------
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-02-14 15:15:34 +01:00
46142cdbdd
Disable administrative doorkeeper routes ( #29187 )
2024-02-13 18:11:47 +00:00
ca8fbda5d0
Add end-to-end test for OCR in media uploads ( #29148 )
2024-02-08 19:13:44 +00:00
a9e91eb955
Add common stub setup for resolv dns in email mx validator spec ( #29140 )
2024-02-08 14:26:45 +00:00
15437e4ad9
Add `context` and `before` to lengthy tag manager spec examples ( #29129 )
2024-02-08 10:03:04 +00:00
5271131658
Extract helper method for repeated form fill in admin/domain_blocks feature spec ( #29128 )
2024-02-08 10:02:53 +00:00
eff447a455
Rewrite signature verification using regexps and `StringScanner` ( #29133 )
2024-02-07 17:24:42 +00:00
95da28d201
Add common `ThreadingHelper` module for specs ( #29116 )
2024-02-07 14:53:29 +00:00
7efc33b909
Move HTTP Signature parsing code to its own class ( #28932 )
2024-02-07 13:35:37 +00:00
da50217b88
Combine repeated requests in `admin/accounts` controller spec ( #29119 )
2024-02-07 10:59:32 +00:00
7ee93b7431
Change `source` attribute of `Suggestion` entity in `/api/v2/suggestions` back to a string ( #29108 )
2024-02-06 17:10:17 +00:00
0df86d77fd
Reduce `RSpec/ExampleLength` in PostStatusService spec example ( #29105 )
2024-02-06 14:36:04 +00:00
2d6ab44556
Reduce request/response round-trips in ap/collections controller spec ( #29102 )
2024-02-06 13:10:00 +00:00
978fdc71ca
Reduce expectation count in example from `ProcessAccountService` spec ( #29100 )
2024-02-06 13:04:02 +00:00
577520b637
Replace deprecated `Sidekiq::Testing` block style ( #29097 )
2024-02-06 12:49:48 +00:00
df7acdcee5
Update markers API spec for error case ( #29096 )
2024-02-06 12:47:04 +00:00
4fb7f611de
Return domain block digests from admin domain blocks API ( #29092 )
2024-02-06 12:38:14 +00:00
4cf07ed78c
Add missing action logging to `api/v1/admin/reports#update` ( #29044 )
2024-02-06 11:34:11 +00:00
66dda7c762
Fix already-invalid reports failing to resolve ( #29027 )
2024-02-06 09:35:27 +00:00
1726085db5
Merge pull request from GHSA-3fjr-858r-92rw
...
* Fix insufficient origin validation
* Bump version to 4.3.0-alpha.1
2024-02-01 15:56:46 +01:00
8b7b0ee598
Configure selenium to use Chrome version 120 ( #29038 )
2024-02-01 09:46:31 +00:00
86fbde7b46
Fix `Style/NumericLiterals` cop in ProfileStories support module ( #28971 )
2024-01-30 15:38:33 +00:00
f91acba70a
Combine repeated requests in account controller concern spec ( #28957 )
2024-01-30 15:32:20 +00:00
ff8937aa2c
Move `api/v1/statuses/*` to request spec ( #28954 )
2024-01-26 17:45:54 +00:00
44f6d285af
Combine repeated subject in ap fetch remote actor service spec ( #28953 )
2024-01-26 17:44:12 +00:00
239244e2ed
Combine repeated subject in ap fetch remote account service spec ( #28952 )
2024-01-26 17:43:08 +00:00
5119fbc9b7
Move `api/v1/admin/trends/links/preview_card_providers` to request spec ( #28951 )
2024-01-26 17:41:39 +00:00
b6baab447d
Move `api/v2/admin/accounts` to request spec ( #28950 )
2024-01-26 17:41:13 +00:00
7adcc0aae3
Move `api/v1/trends/*` to request specs ( #28949 )
2024-01-26 17:40:39 +00:00
0b0ca6f3b8
Move `api/v1/timelines/list` to request spec ( #28948 )
2024-01-26 17:40:15 +00:00
Matt Jankowski