Commit Graph

2228 Commits (f3f63107f263db86021565dad79be497db9e5257)

Author SHA1 Message Date
Matt Jankowski ecdbf15ebe
Remove unused `link_to_older` and `link_to_newer` helper methods () 2024-03-18 08:54:46 +00:00
Matt Jankowski 4f4132f1a1
Add diagnostic message for failure during CLI search deploy () 2024-03-15 14:26:23 +00:00
Matt Jankowski 2e91a9bd34
Add `include_pagination_headers` matcher to check `Link` header in api specs () 2024-03-15 10:17:45 +00:00
Matt Jankowski e75b55a6d7
Extract target account on list method in bulk import row service spec () 2024-03-15 09:31:25 +00:00
Matt Jankowski 974c7672e5
Extract shared behavior methods in oauth feature spec () 2024-03-14 13:42:59 +00:00
Matt Jankowski 0bc17a3d48
Use enum-generated `public_visibility` scope on Status () 2024-03-14 09:31:57 +00:00
Matt Jankowski 681a89f684
Readability clean up in `ImportVacuum` spec () 2024-03-14 09:24:00 +00:00
Matt Jankowski f9100743ec
Add `Api::ErrorHandling` concern for api/base controller () 2024-03-14 09:09:47 +00:00
Matt Jankowski 42875fee52
Add coverage for bad args/options in `CLI::Domains#purge` () 2024-03-14 08:58:53 +00:00
Matt Jankowski 71e5f0f48c
Add coverage for suspended instance actor scenario () 2024-03-13 15:43:40 +00:00
Matt Jankowski 6262ceeb70
Fix `RSpec/DescribedClass` cop () 2024-03-13 15:42:39 +00:00
Matt Jankowski c09b8a7164
Add `Account.without_internal` scope ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-03-13 14:11:23 +00:00
Matt Jankowski 46e902f1f3
Merge `api/v1/accounts/credentials` controller spec into existing request spec () 2024-03-13 09:22:43 +00:00
Matt Jankowski 01b624c4a0
Use `normalizes` on `CustomFilter#context` value () 2024-03-13 08:50:21 +00:00
Matt Jankowski 71eecbfa1f
Move `api/v2/filters/*` to request spec () 2024-03-13 08:47:09 +00:00
Matt Jankowski 8349b45d60
Accept extra args that we wont verify in `ap/activity/add_spec` () 2024-03-13 08:46:11 +00:00
Matt Jankowski 469028b6d3
Remove unneeded `type: :service` from spec/services files () 2024-03-13 08:39:26 +00:00
Matt Jankowski 3eaac3af73
Use `before_all` block to setup `requests/cache_spec` data () 2024-03-13 08:38:57 +00:00
Matt Jankowski 19f0590795
Add basic coverage for `TagSearchService` class () 2024-03-13 08:33:03 +00:00
Matt Jankowski 96013cd576
Reduce `RSpec/ExampleLength` in CSP request spec () 2024-03-13 08:22:32 +00:00
Matt Jankowski 216cea1e27
Fix incorrect frequency value in `FriendsOfFriendsSource` data () 2024-03-12 08:38:32 +00:00
Matt Jankowski 24319836de
Convert request-based setup into factory setup in push/subscriptions request spec () 2024-03-11 15:46:25 +00:00
Matt Jankowski a38e424185
Use unchanging github links in docs/comments () 2024-03-11 15:14:55 +00:00
Eugen Rochko c10bbf5fe3
Add notification policies and notification requests in web UI () 2024-03-11 15:02:21 +00:00
Jeong Arm 4a6ddbc9c0
Normalize idna domain before account unblock domain () 2024-03-11 09:28:08 +00:00
Matt Jankowski a7284690fc
Add coverage for admin/metrics base classes, simplify subclass generation () 2024-03-11 09:16:19 +00:00
Matt Jankowski 98ef38e34e
Ensure unique values in fabricators () 2024-03-11 08:53:24 +00:00
Eugen Rochko 50b17f7e10
Add notification policies and notification requests () 2024-03-07 14:53:37 +00:00
Claire ee8d0b9447
Fix follow suggestions potentially including silenced or blocked accounts () 2024-03-04 06:35:20 +00:00
Matt Jankowski 18945f62e0
Convert more API specs from controller->request style () 2024-03-01 16:24:45 +00:00
Daniel M Brasil a25014de8f
Improve `IpBlock` model test coverage () 2024-03-01 16:17:40 +00:00
Matt Jankowski 3389c41b58
Move `nobody` position in `UserRole` magic number to constant () 2024-03-01 11:05:24 +00:00
Matt Jankowski eb1b8f69de
Allow pagination `Link` headers on API accounts/statuses when pinned true () 2024-02-29 14:21:56 +00:00
Matt Jankowski 6675bf574a
Extract `parsed_uri_query_values` helper in ap/replies controller spec () 2024-02-29 13:47:38 +00:00
Matt Jankowski 14c65180df
Use sequence in `software_update` fabricator to allow multiple () 2024-02-29 10:51:11 +00:00
Matt Jankowski 8f3c91fc3c
Add `change` block expectation to `admin/invites#deactivate_all` spec () 2024-02-27 16:25:58 +00:00
Claire 6f7615ba86
Add basic end-to-end test for admin moderation interface () 2024-02-27 15:18:06 +00:00
Matt Jankowski 9e78129e6e
Use "cacheable response" shared example in more places () 2024-02-27 11:50:21 +00:00
Matt Jankowski 8156113d58
Use `response_vary_headers` method in requests/cache_spec () 2024-02-26 16:27:07 +00:00
Damien Mathieu 1540f42522
Better tests for auth/registrations#update () 2024-02-26 16:09:56 +00:00
Wolfgang Fournès d51c3ac087
Add a missing spec to `SessionsController#webauthn_options` () 2024-02-26 16:09:40 +00:00
Matt Jankowski b0064ddda7
Add basic coverage for `MoveService` class () 2024-02-23 09:59:29 +00:00
Matt Jankowski a6ed148769
Use heredoc on the `HTML` blocks in verify link spec () 2024-02-22 21:26:48 +00:00
Claire 9d8dfeb5fb
Fix processing of `Link` objects in `Image` objects () 2024-02-22 22:27:24 +01:00
Claire 5152dd869e
Fix link verifications when page size exceeds 1MB () 2024-02-22 17:31:50 +00:00
Claire b71904816a
Change registrations to be disabled by default for new servers () 2024-02-22 13:28:19 +00:00
Matt Jankowski e9b0f0c314
Add basic coverage for `RemoveDomainsFromFollowersService` class () 2024-02-22 10:53:38 +00:00
Matt Jankowski 7c7dfe7de3
Add basic coverage for `RemoveFeaturedTagService` class () 2024-02-22 10:51:04 +00:00
Matt Jankowski 6342ddd698
Add basic coverage for `UnfavouriteService` class () 2024-02-22 10:48:42 +00:00
Matt Jankowski f70905f127
Add basic coverage for `UnmuteService` class () 2024-02-22 10:48:09 +00:00
Matt Jankowski a69fe534e3
Add basic coverage for `WebhookService` class () 2024-02-22 10:46:20 +00:00
Matt Jankowski d1602c017d
Add basic coverage for `ApproveAppealService` class () 2024-02-22 10:40:07 +00:00
Matt Jankowski ab2ef63a03
Add basic coverage for `VoteService` class () 2024-02-22 10:39:18 +00:00
Claire 2751acb6cd
Automatically switch from open to approved registrations in absence of moderators () 2024-02-21 17:45:06 +00:00
Matt Jankowski 08342ad40c
Add basic coverage for `AfterUnallowDomainService` class () 2024-02-21 17:13:11 +00:00
Matt Jankowski 8f61e32569
Add basic coverage for `AppealService` class () 2024-02-21 17:12:31 +00:00
Matt Jankowski b73932461f
Add basic coverage for `CreateFeaturedTagService` class () 2024-02-21 16:58:19 +00:00
Matt Jankowski 5f19e7e799
Add basic coverage for `ProcessHashtagsService` class () 2024-02-21 16:57:45 +00:00
Matt Jankowski 1f648fdf1a
Remove erroneous service type on `TagFeed` model spec () 2024-02-21 11:25:33 +00:00
Matt Jankowski 64f9939e39
Use `capture_emails` helper to improve email assertions in specs () 2024-02-19 15:57:47 +00:00
Wolfgang Fournès 86627ea2e4
Add a missing thread example to the statuses spec () 2024-02-19 13:35:58 +00:00
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants () 2024-02-19 11:09:43 +00:00
Claire 96ddf1d482
Fix flaky end-to-end OCR test () 2024-02-16 16:57:23 +00:00
Matt Jankowski 1946e171e6
Reduce round trips in admin/disputes/appeals spec () 2024-02-16 13:46:28 +00:00
Matt Jankowski 3454fcbd71
Reduce round trips in auth/sessions spec () 2024-02-16 13:38:49 +00:00
Matt Jankowski a316c0e38d
Reduce round trips in disputes/appeals spec () 2024-02-16 13:01:15 +00:00
Matt Jankowski 117b507df5
Extract `subject` from `User#mark_email_as_confirmed!` spec () 2024-02-16 13:01:04 +00:00
Matt Jankowski 1690fb39e6
Reduce `RSpec/MultipleExpectations` in instance_actors_controller spec () 2024-02-16 13:00:11 +00:00
Matt Jankowski bba488c189
Reduce `RSpec/MultipleExpectations` in media_attachment spec () 2024-02-16 13:00:09 +00:00
Claire 9fee5e8526
Merge pull request from GHSA-jhrq-qvrm-qr36
* Fix insufficient Content-Type checking of fetched ActivityStreams objects

* Allow JSON-LD documents with multiple profiles
2024-02-16 11:56:12 +01:00
Matt Jankowski a9f9b0097b
Reduce `RSpec/MultipleExpectations` in captcha feature spec () 2024-02-16 07:52:57 +00:00
Matt Jankowski 4b7f04e3ea
Reduce `RSpec/MultipleExpectations` in post_status_service spec () 2024-02-16 07:52:29 +00:00
Matt Jankowski ed4939296a
Reduce `RSpec/MultipleExpectations` in ap/activity/create spec () 2024-02-16 07:43:00 +00:00
Matt Jankowski 1df2ffc3ee
Use `subject` in blacklist email validator spec () 2024-02-16 07:42:03 +00:00
Matt Jankowski fc4f823464
Avoid local block var assignment in ap/process_status_update_service spec () 2024-02-16 07:41:25 +00:00
Claire d4d0565b0f
Fix user creation failure handling in OAuth paths () 2024-02-14 21:49:45 +00:00
Claire bbbbf00084
Fix OmniAuth tests () 2024-02-14 14:57:49 +00:00
Claire b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
2024-02-14 15:16:07 +01:00
Emelia Smith 68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-02-14 15:15:34 +01:00
Emelia Smith 46142cdbdd
Disable administrative doorkeeper routes () 2024-02-13 18:11:47 +00:00
Claire ca8fbda5d0
Add end-to-end test for OCR in media uploads () 2024-02-08 19:13:44 +00:00
Matt Jankowski a9e91eb955
Add common stub setup for resolv dns in email mx validator spec () 2024-02-08 14:26:45 +00:00
Matt Jankowski 15437e4ad9
Add `context` and `before` to lengthy tag manager spec examples () 2024-02-08 10:03:04 +00:00
Matt Jankowski 5271131658
Extract helper method for repeated form fill in admin/domain_blocks feature spec () 2024-02-08 10:02:53 +00:00
Claire eff447a455
Rewrite signature verification using regexps and `StringScanner` () 2024-02-07 17:24:42 +00:00
Matt Jankowski 95da28d201
Add common `ThreadingHelper` module for specs () 2024-02-07 14:53:29 +00:00
Claire 7efc33b909
Move HTTP Signature parsing code to its own class () 2024-02-07 13:35:37 +00:00
Matt Jankowski da50217b88
Combine repeated requests in `admin/accounts` controller spec () 2024-02-07 10:59:32 +00:00
Claire 7ee93b7431
Change `source` attribute of `Suggestion` entity in `/api/v2/suggestions` back to a string () 2024-02-06 17:10:17 +00:00
Matt Jankowski 0df86d77fd
Reduce `RSpec/ExampleLength` in PostStatusService spec example () 2024-02-06 14:36:04 +00:00
Matt Jankowski 2d6ab44556
Reduce request/response round-trips in ap/collections controller spec () 2024-02-06 13:10:00 +00:00
Matt Jankowski 978fdc71ca
Reduce expectation count in example from `ProcessAccountService` spec () 2024-02-06 13:04:02 +00:00
Matt Jankowski 577520b637
Replace deprecated `Sidekiq::Testing` block style () 2024-02-06 12:49:48 +00:00
Matt Jankowski df7acdcee5
Update markers API spec for error case () 2024-02-06 12:47:04 +00:00
Emelia Smith 4fb7f611de
Return domain block digests from admin domain blocks API () 2024-02-06 12:38:14 +00:00
Matt Jankowski 4cf07ed78c
Add missing action logging to `api/v1/admin/reports#update` () 2024-02-06 11:34:11 +00:00
Claire 66dda7c762
Fix already-invalid reports failing to resolve () 2024-02-06 09:35:27 +00:00
Claire 1726085db5
Merge pull request from GHSA-3fjr-858r-92rw
* Fix insufficient origin validation

* Bump version to 4.3.0-alpha.1
2024-02-01 15:56:46 +01:00
Matt Jankowski 8b7b0ee598
Configure selenium to use Chrome version 120 () 2024-02-01 09:46:31 +00:00
Matt Jankowski 86fbde7b46
Fix `Style/NumericLiterals` cop in ProfileStories support module () 2024-01-30 15:38:33 +00:00