Commit Graph

3481 Commits (fb48fc4cceffed33bc14467ea916de984e4e70f2)

Author SHA1 Message Date
Matt Jankowski 6fddf1610c
Fix awkwardly-worded nature of scheduled too soon error (#33156) 2024-12-04 07:43:29 +00:00
Matt Jankowski be43b01eb1
Add coverage for `CustomFilter#expires_in` method (#33142) 2024-12-02 21:52:17 +00:00
Matt Jankowski 2381ed55d7
Add coverage for `Report#unresolved_siblings?` (#33141) 2024-12-02 21:52:12 +00:00
Claire c2817c7fad Merge commit '752d49eefef48262d501ba5fc2006d2c8466a000' into glitch-soc/merge-upstream
Conflicts:
- `app/lib/feed_manager.rb`:
  Upstream changed how notifications from follow subscriptions were handled,
  refactoring this file in the process.
  Conflict is due to glitch-soc having an extra timeline type (direct).
  Ported upstream's changes.
- `app/workers/feed_insert_worker.rb`:
  Ditto.
2024-12-02 21:08:15 +01:00
Matt Jankowski 752d49eefe
Add coverage for `api/v1/push/subscriptions#show` action (#33134) 2024-12-02 15:08:41 +00:00
Jonathan de Jong 360b6d3a44
Fix exclusive lists interfering with notifications (#28162) 2024-12-02 09:26:04 +00:00
Matt Jankowski 3cd308523a
Add shared example for `RankedTrend` concern (#33125) 2024-12-02 00:44:14 +00:00
Claire 7d52d5df0f Merge commit 'c58967c3bd7b7eee0b284ee2b77a48ed9ce6863e' into glitch-soc/merge-upstream
Conflicts:
- `lib/sanitize_ext/sanitize_config.rb`:
  Conflict due to upstream adding fallback support for MathML Core while
  glitch-soc supported slightly more tags than upstream.
  Added the MathML Core fallback code to glitch-soc.
- `spec/lib/sanitize/config_spec.rb`:
  Ditto.
2024-12-01 18:22:00 +01:00
Claire 48827e1210 Merge commit 'a27bafa59653328a0f06bedb1dfb2b6ee92af43d' into glitch-soc/merge-upstream
- `app/controllers/application_controller.rb`:
  Minor conflict due to glitch-soc's theming system.
- `spec/helpers/application_helper_spec.rb`:
  Minor conflict due to glitch-soc's theming system.
2024-12-01 17:36:49 +01:00
Calvin Lee 7f4858b339
Correctly sanitize MathML out of post content (#27107) 2024-11-28 12:02:34 +00:00
Eugen Rochko 48f3ed738f
Fix list error messages (#33082) 2024-11-28 10:13:06 +00:00
Matt Jankowski 0ea9d8164b
Remove `body_class_string` helper (#33072) 2024-11-26 07:19:20 +00:00
Matt Jankowski 74df47ad9c
Add coverage for `Webhook` validations (#33026) 2024-11-25 08:19:16 +00:00
Matt Jankowski ab9c62e8c7
Add coverage for `User` validations (#33028) 2024-11-25 08:18:10 +00:00
Matt Jankowski fd90f04f0e
Add coverage for `UserRole` validations (#33029) 2024-11-25 08:18:07 +00:00
Claire f740611820 Merge commit 'd0753ec276502ea28a1e853cbc6487020a0602e3' into glitch-soc/merge-upstream 2024-11-24 18:56:15 +01:00
Claire 6374937147 Merge commit 'e68b26c8df2056182564abcee230927ed53200c8' into glitch-soc/merge-upstream
Conflicts:
- `app/models/trends/statuses.rb`:
  Upstream added a date restriction to trendable posts, while glitch-soc had
  slightly different conditions.
  Added the date restriction to glitch-soc's conditions.
2024-11-24 16:46:28 +01:00
Christian Schmidt 0518613dd7
LinkDetailsExtractor adjustments (#31357) 2024-11-22 08:00:14 +00:00
Christian Schmidt 7385016837
`rel="me"` check should be case-insenstive (#32238) 2024-11-21 14:37:25 +00:00
Emelia Smith 4517e18b79
Update dependency doorkeeper to v5.8.0 (#33000)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-11-21 13:48:30 +00:00
Paulo Vilarinho 2526b32ad3
block scheduled status from frozen users (#30729) 2024-11-20 19:06:41 +00:00
Matt Jankowski b66fbaeec2
Add `AccountWarning` case to `Report#history` spec (#32984) 2024-11-20 07:52:00 +00:00
Eugen Rochko 2b5faa2ba3
Change lists to reflect added and removed users retroactively (#32930) 2024-11-19 10:04:12 +00:00
Matt Jankowski 87e7ad9b8f
Add `LoginActivity` model spec and `BrowserDetection` concern shared example (#32959) 2024-11-19 09:15:05 +00:00
Matt Jankowski 425982841d
Use group/count approach in annual report classes (#32914) 2024-11-19 08:51:34 +00:00
Matt Jankowski 295ad6f19a
Prep work for coverage addition to `ActivityPub::DeliveryWorker` spec (#32944) 2024-11-18 16:37:21 +00:00
Matt Jankowski 30a7986569
Add coverage for fixing the thing with the dates in the search area (#32958) 2024-11-18 15:42:45 +00:00
Matt Jankowski c0c34d35e2
Move self destruct check to `config_for` and add constant for verifier string (#32943) 2024-11-18 09:57:16 +00:00
Eugen Rochko 911d7dbbf6
Fix `min_id` and `max_id` causing error in search API (#32857) 2024-11-18 09:37:01 +00:00
Matt Jankowski 03ee08c2da
Use `nil` instead of `false` for datetime value in spec (#32926) 2024-11-18 09:31:25 +00:00
Matt Jankowski be413d67de
`Form::Import` spec reduce factories (#32924) 2024-11-18 09:22:09 +00:00
Matt Jankowski a1ac2a73ff
Remove remnants of embed views (#32419) 2024-11-16 20:48:10 +00:00
Claire 4f1242964b Merge commit '44d92fa4f6aac5c45ad358287af48cd879f5665e' into glitch-soc/merge-upstream 2024-11-15 18:44:32 +01:00
Matt Jankowski 9d3fcc3546
Remove unused failure action in api/base controller spec (#32905) 2024-11-15 16:10:20 +00:00
Matt Jankowski 7bd7705f59
Combine shared-setup examples across `spec/controllers/auth/*` specs (#32906) 2024-11-15 16:07:26 +00:00
Matt Jankowski 319109029d
Fix logic in "last used at per application" oauth token list (#32912) 2024-11-15 15:52:37 +00:00
Matt Jankowski 297ce9ef44
Move body class to shared partial for web app controller concern views (#31797) 2024-11-15 15:49:26 +00:00
Claire f1ef7b5b43
Fix uploading higher-than-wide GIF profile picture with libvips enabled (#32911) 2024-11-15 15:35:30 +00:00
Matt Jankowski 766358e52b
Add coverage for malformed version cleanup in `SoftwareUpdateCheckService`, add helper query methods (#32876) 2024-11-14 14:03:57 +00:00
Matt Jankowski 62d65504f6
Add `DomainResource` class to wrap MX lookup/normalize (#32864) 2024-11-14 13:47:29 +00:00
Claire e8b6607ece
Fix titles being escaped twice (#32889) 2024-11-14 13:28:00 +00:00
Claire 8f5cbf5370
Fix list creation limit check (#32869) 2024-11-13 10:22:11 +00:00
Matt Jankowski a6d829e86f
Fix error in CLI EmailDomainBlocks when supplying `--with-dns-records` (#32863) 2024-11-13 08:39:58 +00:00
Emelia Smith 2bd56f726a
Add client_secret_expires_at to OAuth Applications (#30317) 2024-11-12 22:06:13 +00:00
Matt Jankowski 884bbf7ae2
Prepare the way for banning a bunch of usernames (#32856) 2024-11-12 15:43:55 +00:00
Matt Jankowski 5d9dde3ec0
Add age/expiry duration constants to `BulkImport` class (#32839) 2024-11-12 08:57:06 +00:00
Matt Jankowski c099797700
Use `mastodon` config namespace to load software update default value via `config_for` (#30534) 2024-11-12 08:28:31 +00:00
Matt Jankowski c78dc23b49
Move account sensitize-related methods to concern (#28865) 2024-11-11 13:08:23 +00:00
Matt Jankowski d033920b7e
Move account silence-related methods to concern (#28866) 2024-11-11 08:29:55 +00:00
Claire f0f807cec7 Merge commit '1e71c4e247eb8900a718b04113ffce9c1b8ad2f4' into glitch-soc/merge-upstream 2024-11-10 13:18:43 +01:00
Matt Jankowski 4ef3a1a38d
Match dependency-generator output for `require_relative` usage (#32800) 2024-11-08 09:55:15 +00:00
Matt Jankowski 870bb06994
Add coverage for misc serializers (#32781) 2024-11-07 15:37:26 +00:00
Matt Jankowski 41227aeb95
Update Rails to version 7.2.2 (#30391) 2024-11-07 14:58:20 +00:00
Claire 2bea74e69d
Avoid latest featured tag use on post removal unless necessary (#32787) 2024-11-06 10:51:54 +00:00
Eugen Rochko 90f4ffa31d
Fix performance of percentile calculation for annual reports (#32765) 2024-11-04 10:11:06 +00:00
Matt Jankowski ff490daa58
Reduce factory generation in `AccountStatusesFilter` spec (#32727) 2024-11-04 09:00:01 +00:00
Claire f624ef2778 Merge commit 'b06fd54c305915527e3a6edc575dc23b623143ef' into glitch-soc/merge-upstream
Conflicts:
- `app/helpers/formatting_helper.rb`:
  Upstream wrapped some code glitch-soc had modified in an OTEL instrumentation span.
  Wrapped the modified code.
2024-11-03 20:51:58 +01:00
Matt Jankowski b231c3c1bf
Drop support for ruby 3.1 (#32363) 2024-10-31 15:12:08 +00:00
Matt Jankowski a20ac20302
Add model spec for `Tombstone` (#32697) 2024-10-31 13:27:47 +00:00
Eugen Rochko c2b498a2b0
Fix IDs not being serialized as strings in annual reports API (#32710) 2024-10-31 09:38:00 +00:00
Emelia Smith e1b7382ea6
Add userinfo oauth endpoint (#32548) 2024-10-30 14:38:10 +00:00
Matt Jankowski babee06794
Add coverage for `StatusTrend` and `PreviewCardTrend` models, add `locales` class method to `RankedTrend` (#32688) 2024-10-29 15:46:32 +00:00
Matt Jankowski df3b954720
Add `DomainHelpers` spec support module for DNS/MX stub (#32690) 2024-10-29 15:35:25 +00:00
Emelia Smith d94a367aeb
Add test coverage for POST /api/v2/media's max description length (#32683) 2024-10-29 09:25:38 +00:00
Matt Jankowski b107fc2e65
Use nil for timestamp column in admin/confirmations spec (#32682) 2024-10-29 08:54:30 +00:00
Matt Jankowski 1edb527072
Enhance coverage for `StatusPin` model (#32515) 2024-10-28 07:34:58 +00:00
Jonny Saunders 9074c1fac9
Use `likes` and `shares` totalItems on status creations and updates (#32620) 2024-10-28 04:55:18 +00:00
Claire 8103e69b17 Merge commit '77cd16f4ee7ab807df6fffb1538a6659a8182a9e' into glitch-soc/merge-upstream
Conflicts:
- `app/javascript/styles/mastodon/components.scss`:
  Conflict caused by glitch-soc changing the path to images, and upstream
  removing styling using such an image.
  Removed the styling as upstream did.
- `app/models/account.rb`:
  Conflict due to upstream changing lines adjacent to a change made in glitch-soc
  to have configurable limits.
  Ported upstream's changes.
- `yarn.lock`:
  Dependencies adjacent to glitch-soc-only dependencies updated.
  Updated them as well.
2024-10-26 13:38:07 +02:00
Matt Jankowski 1775e151ec
Simplify model validation specs for `DomainAllow` (#32496) 2024-10-25 08:42:14 +00:00
Matt Jankowski 9464281f29
Simplify model validation specs for `AccountStatusCleanupPolicy` (#32495) 2024-10-25 08:41:24 +00:00
Matt Jankowski 15f6336cdd
Simplify model validation specs for `AccountMigration` (#32494) 2024-10-25 08:02:13 +00:00
Matt Jankowski 86132f7dd3
Provide `establish_policy` helper method in `AccountStatusesCleanupPolicy` spec (#32490) 2024-10-25 08:00:58 +00:00
Matt Jankowski 2a13d6824c
Use `subject` for `FeedManager` lib spec (#32486) 2024-10-25 07:59:31 +00:00
Matt Jankowski 2e3bbb6861
Move account suspension related coverage to concern spec (#32432) 2024-10-25 07:58:41 +00:00
Matt Jankowski 4134ccdbe0
Simplify model validation specs for `WebauthnCredential` (#32466) 2024-10-25 07:55:45 +00:00
Matt Jankowski e5be4bf8d8
Simplify model validation specs for `PreviewCard` (#32469) 2024-10-25 07:55:33 +00:00
Matt Jankowski 37bcbeab4a
Simplify model validation spec in AccountModerationNote/ReportNote (#31792) 2024-10-24 12:52:38 +00:00
Matt Jankowski dea6c454fd
Contribute more coverage for `Account` model (#32474) 2024-10-24 12:47:06 +00:00
Matt Jankowski b16435e79f
Explore more resplendent model validation specs for `Form::AdminSettings` (#32465) 2024-10-24 12:44:13 +00:00
Matt Jankowski 67504dbf9c
Simplify uniqueness validation spec for `IpBlock` (#32066) 2024-10-24 12:43:40 +00:00
Matt Jankowski 5c910dc82e
Add coverage for `DatabaseHelper` primary/replica methods (#32642) 2024-10-24 08:04:29 +00:00
Matt Jankowski 745c4f900a
Remove unused `ApplicationHelper#visibility_icon` helper method (#32644) 2024-10-24 08:02:54 +00:00
Matt Jankowski 5a4f4f3e83
Remove single-use `ProfileStories` method (#31164) 2024-10-23 13:31:03 +00:00
Matt Jankowski 2f906ed55a
Constants for account refresh (#32420) 2024-10-23 13:29:01 +00:00
David Roetzel 05f23df3b7
Add endpoint to remove web push subscription (#32626) 2024-10-23 08:02:31 +00:00
Matt Jankowski d1b20ea8f7
Worker specs coverage increase (#32541) 2024-10-23 07:50:20 +00:00
Matt Jankowski bd0c826a3d
Simplify model validation specs for `Announcement` (#32481) 2024-10-23 07:47:46 +00:00
Matt Jankowski c0f46e9031
Fortify coverage for `Follow` model (#32472) 2024-10-23 07:46:55 +00:00
Matt Jankowski 1f3722904f
Top off coverage for `Appeal` model (#32464) 2024-10-23 06:42:57 +00:00
Matt Jankowski 67403e7b01
Add coverage for ActivityPub likes/shares endpoints (#32305) 2024-10-23 06:41:07 +00:00
Matt Jankowski 0a4a73f9a6
Add coverage for `api/v1/domain_blocks/preview` endpoint (#32303) 2024-10-23 06:40:29 +00:00
Matt Jankowski 6d2f865862
Add coverage for `AccountAlias` validations (#31936) 2024-10-23 06:39:19 +00:00
Claire 6281c4dedd Merge commit '1fc165de02d79294c8a218f5fa82bcd477484ca1' into glitch-soc/merge-upstream
Conflicts:
- `.env.production.sample`:
  Upstream added a block of three environment variables, while glitch-soc
  has a different version of the file overall.
  Added upstream's changes.
- `app/helpers/application_helper.rb`:
  Upstream added a helper, while glitch-soc had extra helpers.
  Added upstream's helper.
2024-10-19 19:13:32 +02:00
Matt Jankowski bfe3d49cca
Add `inline_jobs` to admin/reset spec (#32517) 2024-10-16 08:06:34 +00:00
Matt Jankowski c40cd79c4d
Convert `admin/invites` controller specs to system specs (#32450) 2024-10-15 14:27:46 +00:00
Matt Jankowski 9e8f099d38
Improve `app/policies` coverage (#32426) 2024-10-15 14:24:12 +00:00
Matt Jankowski 28131b4b00
Convert status embed controller to request spec (#32448) 2024-10-15 14:18:20 +00:00
Matt Jankowski b78597979a
Fix missing content warning text in rss formatter (#32406) 2024-10-15 14:12:54 +00:00
Matt Jankowski b742ce9d09
Reduce factory creation (17 -> 0) in `PlainTextFormatter` spec (#32487) 2024-10-15 13:58:45 +00:00
Matt Jankowski e9b27852be
Reduce factory creation (14 -> 8) in `ActivityPub::Activity::Block` spec (#32488) 2024-10-15 13:51:52 +00:00
Matt Jankowski 27f05e9016
Expand coverage for `User#token_for_app` (#32434) 2024-10-15 13:43:08 +00:00
Matt Jankowski bfb41e61a3
Expand coverage for `Block` model (#32480) 2024-10-15 13:30:17 +00:00
Christian Schmidt 227d46883f
Translate to regional language variant (e.g. pt-BR) (#32428) 2024-10-15 13:26:20 +00:00
Matt Jankowski 6a39212b02
Reduce factories (36 > 12) in `AccountReachFinder` spec (#32482) 2024-10-15 13:18:57 +00:00
Matt Jankowski 92bb19773a
Use `context` for repeated scenarios in `AccountStatusCleanupPolicy` spec (#32489) 2024-10-15 13:12:58 +00:00
Matt Jankowski d1d2278e70
Reduce factory creation (73 -> 64) in `PublicFeed` spec (#32491) 2024-10-15 13:10:29 +00:00
Matt Jankowski b1c10969ac
Reduce factory creation (48 -> 8) in `AP::Note` serializer spec (#32492) 2024-10-15 13:10:03 +00:00
Matt Jankowski a11b599ffa
Expand coverage for `Scheduler::IpCleanupScheduler` worker (#32499) 2024-10-15 13:09:25 +00:00
Matt Jankowski 0cc21f1ded
Reduce factory creation (132 -> 40) in lib/vacuum/* specs (#32498) 2024-10-15 12:54:56 +00:00
Matt Jankowski d74c2c583a
Extend spec coverage for `Poll` model (#32500) 2024-10-15 12:48:10 +00:00
Claire 4d9b4ef72f Merge commit '7c10b0fb7a078661558fef86399d86831423260c' into glitch-soc/merge-upstream 2024-10-14 19:46:52 +02:00
Matt Jankowski cc70acc11c
Augment coverage for `Status` model (#32468) 2024-10-14 12:52:47 +00:00
Matt Jankowski d8eab3d81f
Reinforce coverage for `DomainBlock` model (#32473) 2024-10-14 12:51:01 +00:00
Matt Jankowski 06d6b35e88
Convert `admin/tags` controller specs to system specs (#32447) 2024-10-14 08:31:12 +00:00
Claire d9fbb071da
Fix notification requests from suspended accounts still being listed (#32354) 2024-10-09 17:29:02 +00:00
Matt Jankowski f49161ab1d
Oauth system spec cleanup / helper method extraction (#32287) 2024-10-08 13:30:54 +00:00
Claire 7e06d724c9 Merge commit '4238da6ee3c93dfd5752e9133cbec958f8ebb18a' into glitch-soc/merge-upstream 2024-10-07 20:45:07 +02:00
Leni Kadali 4238da6ee3
Add error message when user tries to follow their own account (#31910) 2024-10-07 12:05:46 +00:00
Claire b28ce2424c Merge commit 'c40ab43dc703be988c277d4ba6b7987a3a80e16c' into glitch-soc/merge-upstream
Conflicts:
- `app/helpers/application_helper.rb`:
  Upstream added a helper where glitch-soc had its own, not really
  a conflict.
  Added upstream's helper.
- `lib/sanitize_ext/sanitize_config.rb`:
  Upstream renamed a constant that was used slightly differently in glitch-soc.
  Renamed it as upstream did.
2024-10-06 16:07:58 +02:00
Matt Jankowski ebdeac0731
Add coverage for missing status scenario in NotificationMailer (#32256) 2024-10-04 14:15:14 +00:00
Matt Jankowski e4e07b1c34
Reduce factory usage across `spec/services` area (#32098) 2024-10-04 14:11:15 +00:00
Matt Jankowski 463f9197d8
Add regression coverage for admin reports resolution button within form (#32248) 2024-10-04 12:21:55 +00:00
Matt Jankowski cc8d723e71
Register an XML encoder for response tests (#32220) 2024-10-03 13:10:27 +00:00
Matt Jankowski d95f6f4410
Extract `ExportSummary` class for account object counts (#32227) 2024-10-03 13:09:58 +00:00
Matt Jankowski b7bb850efd
Enable hostname config for all system specs (#32109) 2024-10-02 13:56:26 +00:00
Matt Jankowski d270d6dd4f
Provide `use_path` to qr generator for svg data size reduction (#32127) 2024-10-02 13:26:46 +00:00
Matt Jankowski 2151dfb8d6
Add `relevant_params` to ReportFilter (matches account filter) (#32136) 2024-10-02 13:24:40 +00:00
Matt Jankowski 4aa26eba53
Extract `WebPushRequest` from push notification worker and subscription (#32208) 2024-10-02 11:11:52 +00:00
Matt Jankowski ebab3b80c7
Expand coverage for `Export` utility class (#32212) 2024-10-02 09:43:04 +00:00
Christian Schmidt 33d3ca7cf1
Support /.well-known/host-meta.json (#32206) 2024-10-02 09:23:44 +00:00
Jeong Arm 66b2bc1c84
Ignore error if mentioned account was not processable (#29215)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2024-10-02 08:08:02 +00:00
David Roetzel e6cda8388c
Move OTP secret length to configuration (#32125) 2024-10-01 09:38:42 +00:00
Claire 7ef25ae53b Merge commit '9d664f87a04b6a5157ddbe60ee33b5b7a960198e' into glitch-soc/merge-upstream 2024-09-29 11:06:09 +02:00
Matt Jankowski cdd7526531
Remove completed TODO note in tags request spec (#32108) 2024-09-27 08:22:40 +00:00
Claire 513f187daf
Add “A Mastodon update is available.” message on admin dashboard for non-bugfix updates (#32106) 2024-09-26 19:27:57 +00:00
Matt Jankowski db57fe80c8
Remove `page_json` var from ap/replies spec (#32000) 2024-09-26 08:54:01 +00:00
Claire 633165ba9c Merge commit '28966fa0a6d7b98ee94696acdc79e45449ce8349' into glitch-soc/merge-upstream 2024-09-25 17:41:37 +02:00
Renaud Chaput 28966fa0a6
Remove deprecated `v2_alpha` endpoint for grouped notifications (#32089) 2024-09-25 15:21:11 +00:00
Matt Jankowski 51777fe3e2
Prefer structure checks over multi-line size/parts checks in `parsed_body` (#32063) 2024-09-25 13:54:22 +00:00
Renaud Chaput 3dc4ddc663
Fix search params being dropped when redirected to non-deck path (#31984) 2024-09-25 13:35:37 +00:00
Matt Jankowski 83574f641a
Add coverage and use mailer callback to check functional user in notification mailer (#32055) 2024-09-25 08:07:48 +00:00
Matt Jankowski c2ef83ea4c
Consolidate shared `a scope` example parts into one attributes check (#32046) 2024-09-25 07:56:42 +00:00
Matt Jankowski c3b6a7a297
Reduce factory creation (36 -> 12) in `spec/controllers/oauth/*` area (#32045) 2024-09-25 07:56:08 +00:00
Matt Jankowski 06ecf9008b
Remove single-use shared examples in controller specs (#32044) 2024-09-25 07:50:15 +00:00
Claire c6039f99ce Merge commit '70988519df66f0b8edeb6ca95140f1d3e436fea8' into glitch-soc/merge-upstream 2024-09-24 19:34:30 +02:00
André Menrath 556837f156
Fix the summary of converted object types to be treated as HTML (#28629) 2024-09-24 15:57:53 +00:00
Claire c36a76b9eb
Fix error when accepting appeal for sensitive posts deleted in the meantime (#32037)
Co-authored-by: David Roetzel <david@roetzel.de>
2024-09-24 15:19:55 +00:00
Matt Jankowski 780e2e9d66
Convert notification mailer spec shared examples to matchers (#32047) 2024-09-24 12:07:16 +00:00
Claire c2c3a66478 Merge commit '5dfdec645313e556413147597138a8008bc35996' into glitch-soc/merge-upstream 2024-09-23 20:24:18 +02:00
Matt Jankowski 5dfdec6453
Convert `settings/applications` controller spec to system/request specs (#32006) 2024-09-23 13:37:32 +00:00