From 208099c2dceeaee25fdc033520842f9b8abfd88f Mon Sep 17 00:00:00 2001 From: Hiro-Aki Hotta Date: Sun, 22 Dec 2019 01:43:36 +0900 Subject: [PATCH] fix: Use getDerivedStateFromProps instead of componentWillReceiveProps (#372) * use getDerivedStateFromProps instead of componentWillReceiveProps * code formatting --- src/components/picker/nimble-picker.js | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/components/picker/nimble-picker.js b/src/components/picker/nimble-picker.js index dc8e40a..7873a4f 100644 --- a/src/components/picker/nimble-picker.js +++ b/src/components/picker/nimble-picker.js @@ -176,12 +176,19 @@ export default class NimblePicker extends React.PureComponent { this.handleKeyDown = this.handleKeyDown.bind(this) } - componentWillReceiveProps(props) { + static getDerivedStateFromProps(props, state) { if (props.skin) { - this.setState({ skin: props.skin }) + return { + ...state, + skin: props.skin, + } } else if (props.defaultSkin && !store.get('skin')) { - this.setState({ skin: props.defaultSkin }) + return { + ...state, + skin: props.defaultSkin, + } } + return state } componentDidMount() {