Merge pull request #321 from pederjohnsen/return_skin_emoji_on_search

Return skin emoji on search
release
Nolan Lawson 2019-03-23 09:18:26 -07:00 committed by GitHub
commit d9eda6a7a5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 78 additions and 8 deletions

View File

@ -0,0 +1,24 @@
import NimbleEmojiIndex from '../nimble-emoji-index.js'
import store from '../../store'
import data from '../../../../data/all'
const nimbleEmojiIndex = new NimbleEmojiIndex(data);
function getEmojiData(skinTone) {
store.update({skin: skinTone})
return nimbleEmojiIndex.search('thumbsup')[0]
}
test('should return emojis with skin tone 1', () => {
const skinTone = 1
const emoji = getEmojiData(skinTone)
expect(emoji.skin).toEqual(skinTone)
})
test('should return emojis with skin tone 6', () => {
const skinTone = 6
const emoji = getEmojiData(skinTone)
expect(emoji.skin).toEqual(skinTone)
})

View File

@ -1,13 +1,15 @@
import { getData, getSanitizedData, intersect } from '..' import { getData, getSanitizedData, intersect } from '..'
import { uncompress } from '../data' import { uncompress } from '../data'
import store from '../store'
export default class NimbleEmojiIndex { export default class NimbleEmojiIndex {
constructor(data) { constructor(data, set) {
if (data.compressed) { if (data.compressed) {
uncompress(data) uncompress(data)
} }
this.data = data || {} this.data = data || {}
this.set = set || null
this.originalPool = {} this.originalPool = {}
this.index = {} this.index = {}
this.emojis = {} this.emojis = {}
@ -20,7 +22,7 @@ export default class NimbleEmojiIndex {
buildIndex() { buildIndex() {
for (let emoji in this.data.emojis) { for (let emoji in this.data.emojis) {
let emojiData = this.data.emojis[emoji], let emojiData = this.data.emojis[emoji],
{ short_names, emoticons } = emojiData, { short_names, emoticons, skin_variations } = emojiData,
id = short_names[0] id = short_names[0]
if (emoticons) { if (emoticons) {
@ -33,7 +35,16 @@ export default class NimbleEmojiIndex {
}) })
} }
this.emojis[id] = getSanitizedData(id, null, null, this.data) // If skin variations include them
if (skin_variations) {
this.emojis[id] = {}
for (let skinTone = 1; skinTone <= 6; skinTone++) {
this.emojis[id][skinTone] = getSanitizedData({id, skin: skinTone}, skinTone, this.set, this.data)
}
} else {
this.emojis[id] = getSanitizedData(id, null, this.set, this.data)
}
this.originalPool[id] = emojiData this.originalPool[id] = emojiData
} }
} }
@ -70,6 +81,8 @@ export default class NimbleEmojiIndex {
if (this.customEmojisList != custom) if (this.customEmojisList != custom)
this.addCustomToPool(custom, this.originalPool) this.addCustomToPool(custom, this.originalPool)
const skinTone = store.get('skin') || 1;
maxResults || (maxResults = 75) maxResults || (maxResults = 75)
include || (include = []) include || (include = [])
exclude || (exclude = []) exclude || (exclude = [])
@ -79,7 +92,7 @@ export default class NimbleEmojiIndex {
if (value.length) { if (value.length) {
if (value == '-' || value == '-1') { if (value == '-' || value == '-1') {
return [this.emojis['-1']] return [this.emojis['-1'][skinTone]]
} }
var values = value.toLowerCase().split(/[\s|,|\-|_]+/), var values = value.toLowerCase().split(/[\s|,|\-|_]+/),
@ -148,7 +161,11 @@ export default class NimbleEmojiIndex {
let score = subIndex + 1 let score = subIndex + 1
if (sub == id) score = 0 if (sub == id) score = 0
aIndex.results.push(this.emojis[id]) if (this.emojis[id] && this.emojis[id][skinTone]) {
aIndex.results.push(this.emojis[id][skinTone])
} else {
aIndex.results.push(this.emojis[id])
}
aIndex.pool[id] = emoji aIndex.pool[id] = emoji
scores[id] = score scores[id] = score

View File

@ -104,7 +104,7 @@ function getData(emoji, skin, set, data) {
emojiData.emoticons || (emojiData.emoticons = []) emojiData.emoticons || (emojiData.emoticons = [])
emojiData.variations || (emojiData.variations = []) emojiData.variations || (emojiData.variations = [])
if (emojiData.skin_variations && skin > 1 && set) { if (emojiData.skin_variations && skin > 1) {
emojiData = JSON.parse(_JSON.stringify(emojiData)) emojiData = JSON.parse(_JSON.stringify(emojiData))
var skinKey = SKINS[skin - 1], var skinKey = SKINS[skin - 1],
@ -115,8 +115,9 @@ function getData(emoji, skin, set, data) {
} }
if ( if (
(set &&
variationData[`has_img_${set}`] == undefined || variationData[`has_img_${set}`] == undefined ||
variationData[`has_img_${set}`] variationData[`has_img_${set}`]) || !set
) { ) {
emojiData.skin_tone = skin emojiData.skin_tone = skin

View File

@ -11,7 +11,8 @@ import {
color, color,
} from '@storybook/addon-knobs' } from '@storybook/addon-knobs'
import { Picker, Emoji, emojiIndex } from '../dist' import { Picker, Emoji, emojiIndex, NimbleEmojiIndex } from '../dist'
import data from '../data/all.json'
import '../css/emoji-mart.css' import '../css/emoji-mart.css'
const SETS = ['apple', 'google', 'twitter', 'emojione', 'messenger', 'facebook'] const SETS = ['apple', 'google', 'twitter', 'emojione', 'messenger', 'facebook']
@ -214,3 +215,30 @@ storiesOf('Headless Search', module)
</div> </div>
) )
}) })
.add('With skin tone from store', () => {
const nimbleEmojiIndex = new NimbleEmojiIndex(data)
let results = nimbleEmojiIndex.search(text('Search', 'thumbs'), {
custom: CUSTOM_EMOJIS,
})
if (!results) {
return null
}
return (
<div>
{results.map((emoji) => {
return (
<span key={emoji.id} style={{ marginLeft: '1.4em' }}>
<Emoji
native={true}
emoji={emoji}
skin={emoji.skin || 1}
size={48}
/>
</span>
)
})}
</div>
)
})