treehouse
/
mastodon
21
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

Avoid repeated factory creation in media_attachments_vacuum_spec (#31000)

main
Matt Jankowski 2024-07-12 10:09:16 -04:00 committed by GitHub
parent c953dca1de
commit 00cb4a0313
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
spec/lib/vacuum/media_attachments_vacuum_spec.rb
View File

@ -17,32 +17,21 @@ RSpec.describe Vacuum::MediaAttachmentsVacuum do
let!(:old_unattached_media) { Fabricate(:media_attachment, account_id: nil, created_at: 10.days.ago) } let!(:old_unattached_media) { Fabricate(:media_attachment, account_id: nil, created_at: 10.days.ago) }
let!(:new_unattached_media) { Fabricate(:media_attachment, account_id: nil, created_at: 1.hour.ago) } let!(:new_unattached_media) { Fabricate(:media_attachment, account_id: nil, created_at: 1.hour.ago) }
before do before { subject.perform }
subject.perform
end
it 'deletes cache of remote media attachments past the retention period' do it 'handles attachments based on metadata details' do
expect(old_remote_media.reload.file).to be_blank expect(old_remote_media.reload.file) # Remote and past retention period
end .to be_blank
expect(old_local_media.reload.file) # Local and past retention
it 'does not touch local media attachments past the retention period' do .to_not be_blank
expect(old_local_media.reload.file).to_not be_blank expect(new_remote_media.reload.file) # Remote and within retention
end .to_not be_blank
expect(new_local_media.reload.file) # Local and within retention
it 'does not delete cache of remote media attachments within the retention period' do .to_not be_blank
expect(new_remote_media.reload.file).to_not be_blank expect { old_unattached_media.reload } # Unattached and past TTL
end .to raise_error(ActiveRecord::RecordNotFound)
expect(new_unattached_media.reload) # Unattached and within TTL
it 'does not touch local media attachments within the retention period' do .to be_persisted
expect(new_local_media.reload.file).to_not be_blank
end
it 'deletes unattached media attachments past TTL' do
expect { old_unattached_media.reload }.to raise_error(ActiveRecord::RecordNotFound)
end
it 'does not delete unattached media attachments within TTL' do
expect(new_unattached_media.reload).to be_persisted
end end
end end
end end