From 0fb7252ac496f23f9b8ef4b9642fcabcb842c14a Mon Sep 17 00:00:00 2001 From: unarist Date: Tue, 27 Mar 2018 12:22:58 +0900 Subject: [PATCH] Add a spec for UniqueUsernameValidator (#6927) Note that this spec has a pending test about dots in the username, because allowing it has been reverted for now. --- .../unique_username_validator_spec.rb | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 spec/validators/unique_username_validator_spec.rb diff --git a/spec/validators/unique_username_validator_spec.rb b/spec/validators/unique_username_validator_spec.rb new file mode 100644 index 0000000000..b9d773bed3 --- /dev/null +++ b/spec/validators/unique_username_validator_spec.rb @@ -0,0 +1,33 @@ +# frozen_string_literal: true + +require 'rails_helper' + +describe UniqueUsernameValidator do + describe '#validate' do + it 'does not add errors if username is nil' do + account = double(username: nil, persisted?: false, errors: double(add: nil)) + subject.validate(account) + expect(account.errors).to_not have_received(:add) + end + + it 'does not add errors when existing one is subject itself' do + account = Fabricate(:account, username: 'abcdef') + expect(account).to be_valid + end + + it 'adds an error when the username is already used with ignoring dots' do + pending 'allowing dots in username is still in development' + Fabricate(:account, username: 'abcd.ef') + account = double(username: 'ab.cdef', persisted?: false, errors: double(add: nil)) + subject.validate(account) + expect(account.errors).to have_received(:add) + end + + it 'adds an error when the username is already used with ignoring cases' do + Fabricate(:account, username: 'ABCdef') + account = double(username: 'abcDEF', persisted?: false, errors: double(add: nil)) + subject.validate(account) + expect(account.errors).to have_received(:add) + end + end +end