Autofix Rubocop Lint/UnusedBlockArgument (#23712)

lolsob-rspec
Nick Schonning 2023-02-19 20:45:50 -05:00 committed by GitHub
parent a25f6522da
commit 181617e3d9
3 changed files with 3 additions and 11 deletions

View File

@ -278,14 +278,6 @@ Lint/OrAssignmentToConstant:
Exclude: Exclude:
- 'lib/sanitize_ext/sanitize_config.rb' - 'lib/sanitize_ext/sanitize_config.rb'
# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
Lint/UnusedBlockArgument:
Exclude:
- 'spec/lib/activitypub/activity/add_spec.rb'
- 'spec/lib/request_pool_spec.rb'
# Offense count: 33 # Offense count: 33
Lint/UselessAssignment: Lint/UselessAssignment:
Exclude: Exclude:

View File

@ -48,7 +48,7 @@ RSpec.describe ActivityPub::Activity::Add do
end end
it 'fetches the status and pins it' do it 'fetches the status and pins it' do
allow(service_stub).to receive(:call) do |uri, id: true, on_behalf_of: nil, request_id: nil| allow(service_stub).to receive(:call) do |uri, id: true, on_behalf_of: nil, request_id: nil| # rubocop:disable Lint/UnusedBlockArgument
expect(uri).to eq 'https://example.com/unknown' expect(uri).to eq 'https://example.com/unknown'
expect(id).to eq true expect(id).to eq true
expect(on_behalf_of&.following?(sender)).to eq true expect(on_behalf_of&.following?(sender)).to eq true
@ -62,7 +62,7 @@ RSpec.describe ActivityPub::Activity::Add do
context 'when there is no local follower' do context 'when there is no local follower' do
it 'tries to fetch the status' do it 'tries to fetch the status' do
allow(service_stub).to receive(:call) do |uri, id: true, on_behalf_of: nil, request_id: nil| allow(service_stub).to receive(:call) do |uri, id: true, on_behalf_of: nil, request_id: nil| # rubocop:disable Lint/UnusedBlockArgument
expect(uri).to eq 'https://example.com/unknown' expect(uri).to eq 'https://example.com/unknown'
expect(id).to eq true expect(id).to eq true
expect(on_behalf_of).to eq nil expect(on_behalf_of).to eq nil

View File

@ -33,7 +33,7 @@ describe RequestPool do
subject subject
threads = 20.times.map do |i| threads = 20.times.map do |_i|
Thread.new do Thread.new do
20.times do 20.times do
subject.with('http://example.com') do |http_client| subject.with('http://example.com') do |http_client|