From 1bf6ec3325449ad692fdc1eb31737130ebb1fabf Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Sat, 13 Nov 2021 23:07:13 +0100 Subject: [PATCH] Fix no link previews being generated for pages with invalid structured data (#16979) Fix #16955 --- app/lib/link_details_extractor.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/lib/link_details_extractor.rb b/app/lib/link_details_extractor.rb index 3876173e0d..8b38e8d0c6 100644 --- a/app/lib/link_details_extractor.rb +++ b/app/lib/link_details_extractor.rb @@ -59,7 +59,7 @@ class LinkDetailsExtractor end def json - @json ||= Oj.load(@data) + @json ||= first_of_value(Oj.load(@data)) end end @@ -178,6 +178,8 @@ class LinkDetailsExtractor @structured_data ||= begin json_ld = document.xpath('//script[@type="application/ld+json"]').map(&:content).first json_ld.present? ? StructuredData.new(json_ld) : nil + rescue Oj::ParseError + nil end end