treehouse
/
mastodon
21
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

Match report validation spec to extracted constant (#30633)

main-rebase-security-fix
Matt Jankowski 2024-06-10 11:04:01 -04:00 committed by GitHub
parent 92b3004bf3
commit 3e3f3d7580
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
spec/models/report_spec.rb
View File

@ -123,14 +123,14 @@ describe Report do
describe 'validations' do
let(:remote_account) { Fabricate(:account, domain: 'example.com', protocol: :activitypub, inbox_url: 'http://example.com/inbox') }
it 'is invalid if comment is longer than 1000 characters only if reporter is local' do
report = Fabricate.build(:report, comment: Faker::Lorem.characters(number: 1001))
it 'is invalid if comment is longer than character limit and reporter is local' do
report = Fabricate.build(:report, comment: comment_over_limit)
expect(report.valid?).to be false
expect(report).to model_have_error_on_field(:comment)
end
it 'is valid if comment is longer than 1000 characters and reporter is not local' do
report = Fabricate.build(:report, account: remote_account, comment: Faker::Lorem.characters(number: 1001))
it 'is valid if comment is longer than character limit and reporter is not local' do
report = Fabricate.build(:report, account: remote_account, comment: comment_over_limit)
expect(report.valid?).to be true
end
@ -146,5 +146,9 @@ describe Report do
expect(report.valid?).to be false
expect(report).to model_have_error_on_field(:rule_ids)
end
def comment_over_limit
'a' * described_class::COMMENT_SIZE_LIMIT * 2
end
end
end