treehouse
/
mastodon
21
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

HTML string attributes set as booleans (#24408)

lolsob-rspec
Nick Schonning 2023-04-04 10:33:33 -04:00 committed by GitHub
parent 14cf7de141
commit 4ba81aa8dd
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/javascript/mastodon/features/emoji/emoji.js
View File

@ -50,7 +50,7 @@ const emojifyTextNode = (node, customEmojis) => {
if (shortname in customEmojis) { if (shortname in customEmojis) {
const filename = autoPlayGif ? customEmojis[shortname].url : customEmojis[shortname].static_url; const filename = autoPlayGif ? customEmojis[shortname].url : customEmojis[shortname].static_url;
replacement = document.createElement('img'); replacement = document.createElement('img');
replacement.setAttribute('draggable', false); replacement.setAttribute('draggable', 'false');
replacement.setAttribute('class', 'emojione custom-emoji'); replacement.setAttribute('class', 'emojione custom-emoji');
replacement.setAttribute('alt', shortname); replacement.setAttribute('alt', shortname);
replacement.setAttribute('title', shortname); replacement.setAttribute('title', shortname);
@ -65,7 +65,7 @@ const emojifyTextNode = (node, customEmojis) => {
const { filename, shortCode } = unicodeMapping[match]; const { filename, shortCode } = unicodeMapping[match];
const title = shortCode ? `:${shortCode}:` : ''; const title = shortCode ? `:${shortCode}:` : '';
replacement = document.createElement('img'); replacement = document.createElement('img');
replacement.setAttribute('draggable', false); replacement.setAttribute('draggable', 'false');
replacement.setAttribute('class', 'emojione'); replacement.setAttribute('class', 'emojione');
replacement.setAttribute('alt', match); replacement.setAttribute('alt', match);
replacement.setAttribute('title', title); replacement.setAttribute('title', title);

4
app/javascript/packs/public.jsx
View File

@ -291,10 +291,10 @@ function main() {
if (sidebar.classList.contains('visible')) { if (sidebar.classList.contains('visible')) {
document.body.style.overflow = null; document.body.style.overflow = null;
toggleButton.setAttribute('aria-expanded', false); toggleButton.setAttribute('aria-expanded', 'false');
} else { } else {
document.body.style.overflow = 'hidden'; document.body.style.overflow = 'hidden';
toggleButton.setAttribute('aria-expanded', true); toggleButton.setAttribute('aria-expanded', 'true');
} }
toggleButton.classList.toggle('active'); toggleButton.classList.toggle('active');