treehouse
/
mastodon
21
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

A11y: Explicit <form> element around compose area (#19742)

lolsob-rspec
Sunny Ripert 2022-11-04 17:08:08 +01:00 committed by GitHub
parent 4b0e72b2b7
commit 5404fa8bc0
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/javascript/mastodon/components/button.js
View File

@ -6,6 +6,7 @@ export default class Button extends React.PureComponent {
static propTypes = { static propTypes = {
text: PropTypes.node, text: PropTypes.node,
type: PropTypes.string,
onClick: PropTypes.func, onClick: PropTypes.func,
disabled: PropTypes.bool, disabled: PropTypes.bool,
block: PropTypes.bool, block: PropTypes.bool,
@ -42,6 +43,7 @@ export default class Button extends React.PureComponent {
onClick={this.handleClick} onClick={this.handleClick}
ref={this.setRef} ref={this.setRef}
title={this.props.title} title={this.props.title}
type={this.props.type}
> >
{this.props.text || this.props.children} {this.props.text || this.props.children}
</button> </button>

12
app/javascript/mastodon/features/compose/components/compose_form.js
View File

@ -217,7 +217,7 @@ class ComposeForm extends ImmutablePureComponent {
} }
return ( return (
<div className='compose-form'> <form className='compose-form'>
<WarningContainer /> <WarningContainer />
<ReplyIndicatorContainer /> <ReplyIndicatorContainer />
@ -279,10 +279,16 @@ class ComposeForm extends ImmutablePureComponent {
<div className='compose-form__publish'> <div className='compose-form__publish'>
<div className='compose-form__publish-button-wrapper'> <div className='compose-form__publish-button-wrapper'>
<Button text={publishText} onClick={this.handleSubmit} disabled={!this.canSubmit()} block /> <Button
</div> type="submit"
text={publishText}
onClick={this.handleSubmit}
disabled={!this.canSubmit()}
block
/>
</div> </div>
</div> </div>
</form>
); );
} }