treehouse
/
mastodon
22
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

Prepend check_enabled_deletion to Settings::DeletesController (#229) 

The specs for Settings::DeletesController include an example that
sets Settings.open_deletion to false and expects the "if deletion is not
available, redirect to root" logic to run.  However, this spec does not
set up a user, which means that the spec (intentionally or otherwise)
expects this redirection to work with unauthenticated access.

We should preserve that behavior.  To do so, we prepend the deletion
check to the action chain set up by Settings::BaseController, so that
said check occurs before the authenticate_user! check.
lolsob-rspec
David Yip 2017-12-06 16:19:43 -06:00
parent fd7be49523
commit 63c41247ff
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/settings/deletes_controller.rb
View File

@ -2,7 +2,7 @@
class Settings::DeletesController < Settings::BaseController class Settings::DeletesController < Settings::BaseController
before_action :check_enabled_deletion prepend_before_action :check_enabled_deletion
def show def show
@confirmation = Form::DeleteConfirmation.new @confirmation = Form::DeleteConfirmation.new