Catch Paperclip errors on /api/v1/media, return early from update profile service if XML given is nil

lolsob-rspec
Eugen Rochko 2016-10-06 14:39:34 +02:00
parent 8a789b0566
commit 96cc77ce55
2 changed files with 6 additions and 0 deletions

View File

@ -4,5 +4,9 @@ class Api::V1::MediaController < ApiController
def create
@media = MediaAttachment.create!(account: current_user.account, file: params[:file])
rescue Paperclip::Errors::NotIdentifiedByImageMagickError
render json: { error: 'File type of uploaded media could not be verified' }, status: 422
rescue Paperclip::Error
render json: { error: 'Error processing thumbnail for uploaded media' }, status: 500
end
end

View File

@ -1,5 +1,7 @@
class UpdateRemoteProfileService < BaseService
def call(author_xml, account)
return if author_xml.nil?
if author_xml.at_xpath('./poco:displayName').nil?
account.display_name = account.username
else