From 980472efc839519aa4594fb7bda7759964beac65 Mon Sep 17 00:00:00 2001
From: Claire <claire.github-309c@sitedethib.com>
Date: Mon, 6 Mar 2023 16:00:08 +0100
Subject: [PATCH] Fix unconfirmed accounts being registered as active users
 (#23803)

---
 app/models/user.rb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/models/user.rb b/app/models/user.rb
index 5e106dee57..d56a9b9ca1 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -507,11 +507,14 @@ class User < ApplicationRecord
   def prepare_new_user!
     BootstrapTimelineWorker.perform_async(account_id)
     ActivityTracker.increment('activity:accounts:local')
+    ActivityTracker.record('activity:logins', id)
     UserMailer.welcome(self).deliver_later
     TriggerWebhookWorker.perform_async('account.approved', 'Account', account_id)
   end
 
   def prepare_returning_user!
+    return unless confirmed?
+
     ActivityTracker.record('activity:logins', id)
     regenerate_feed! if needs_feed_update?
   end