treehouse
/
mastodon
21
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

Use strict equality rather than Immutable.is as the compared props are values

lolsob-rspec
Thibaut Girka 2019-07-01 12:45:18 +02:00 committed by ThibG
parent e4ffc42c8c
commit bcbc9ed7f6
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/javascript/flavours/glitch/components/intersection_observer_article.js
View File

@ -1,9 +1,7 @@
import React from 'react'; import React from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import ImmutablePureComponent from 'react-immutable-pure-component';
import scheduleIdleTask from 'flavours/glitch/util/schedule_idle_task'; import scheduleIdleTask from 'flavours/glitch/util/schedule_idle_task';
import getRectFromEntry from 'flavours/glitch/util/get_rect_from_entry'; import getRectFromEntry from 'flavours/glitch/util/get_rect_from_entry';
import { is } from 'immutable';
// Diff these props in the "unrendered" state // Diff these props in the "unrendered" state
const updateOnPropsForUnrendered = ['id', 'index', 'listLength', 'cachedHeight']; const updateOnPropsForUnrendered = ['id', 'index', 'listLength', 'cachedHeight'];
@ -34,7 +32,7 @@ export default class IntersectionObserverArticle extends React.Component {
} }
// If we are and remain hidden, diff based on props // If we are and remain hidden, diff based on props
if (isUnrendered) { if (isUnrendered) {
return !updateOnPropsForUnrendered.every(prop => is(nextProps[prop], this.props[prop])); return !updateOnPropsForUnrendered.every(prop => nextProps[prop] === this.props[prop]);
} }
// Else, assume the children have changed // Else, assume the children have changed
return true; return true;