Improve IP cleanup query (#11871)

2019-09-17 15:44:25 +09:00 · 2019-09-17 15:44:25 +09:00 · c21386cff5
parent 3d14b8f28f
commit c21386cff5
1 changed files with 2 additions and 2 deletions
--- a/app/workers/scheduler/ip_cleanup_scheduler.rb
+++ b/app/workers/scheduler/ip_cleanup_scheduler.rb
@ -9,7 +9,7 @@ class Scheduler::IpCleanupScheduler

  def perform
    time_ago = RETENTION_PERIOD.ago
-    SessionActivation.where('updated_at < ?', time_ago).destroy_all
-    User.where('last_sign_in_at < ?', time_ago).update_all(last_sign_in_ip: nil)
+    SessionActivation.where('updated_at < ?', time_ago).in_batches.destroy_all
+    User.where('last_sign_in_at < ?', time_ago).where.not(last_sign_in_ip: nil).in_batches.update_all(last_sign_in_ip: nil)
  end
 end