treehouse
/
mastodon
21
8
Fork 5
Code Issues 32 Pull Requests Projects 1 Releases Wiki Activity

Don't create attachments if remote file cannot be fetched

lolsob-rspec
Eugen Rochko 2016-11-18 23:16:34 +01:00
parent 8d767b477f
commit d2029a8845
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/media_attachment.rb
View File

@ -22,8 +22,6 @@ class MediaAttachment < ApplicationRecord
def file_remote_url=(url) def file_remote_url=(url)
self.file = URI.parse(url) self.file = URI.parse(url)
rescue OpenURI::HTTPError => e
Rails.logger.debug "Error fetching remote attachment: #{e}"
end end
def image? def image?

2
app/services/process_feed_service.rb
View File

@ -173,7 +173,7 @@ class ProcessFeedService < BaseService
begin begin
media.file_remote_url = link['href'] media.file_remote_url = link['href']
media.save media.save
rescue Paperclip::Errors::NotIdentifiedByImageMagickError rescue OpenURI::HTTPError, Paperclip::Errors::NotIdentifiedByImageMagickError
next next
end end
end end