From dc0bf870900d91f710e2ef4219286ac9ce0a644f Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Tue, 7 Nov 2023 10:19:17 -0500
Subject: [PATCH] Remove unused before block from settings/branding spec
(#27759)
---
.rubocop_todo.yml | 1 -
spec/controllers/admin/settings/branding_controller_spec.rb | 4 ----
2 files changed, 5 deletions(-)
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 0792194dd4..a2de86c2eb 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -55,7 +55,6 @@ RSpec/AnyInstance:
- 'spec/controllers/activitypub/inboxes_controller_spec.rb'
- 'spec/controllers/admin/accounts_controller_spec.rb'
- 'spec/controllers/admin/resets_controller_spec.rb'
- - 'spec/controllers/admin/settings/branding_controller_spec.rb'
- 'spec/controllers/auth/sessions_controller_spec.rb'
- 'spec/controllers/settings/two_factor_authentication/confirmations_controller_spec.rb'
- 'spec/controllers/settings/two_factor_authentication/recovery_codes_controller_spec.rb'
diff --git a/spec/controllers/admin/settings/branding_controller_spec.rb b/spec/controllers/admin/settings/branding_controller_spec.rb
index 4b0f1e21e0..435616022a 100644
--- a/spec/controllers/admin/settings/branding_controller_spec.rb
+++ b/spec/controllers/admin/settings/branding_controller_spec.rb
@@ -19,10 +19,6 @@ RSpec.describe Admin::Settings::BrandingController do
end
describe 'PUT #update' do
- before do
- allow_any_instance_of(Form::AdminSettings).to receive(:valid?).and_return(true)
- end
-
around do |example|
before = Setting.site_short_description
Setting.site_short_description = nil