Combine repeated subject in `cacheable response` shared example (#28945)

main-rebase-security-fix
Matt Jankowski 2024-01-26 11:37:05 -05:00 committed by GitHub
parent d791bca11b
commit e519f113e8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 10 deletions

View File

@ -1,22 +1,14 @@
# frozen_string_literal: true # frozen_string_literal: true
shared_examples 'cacheable response' do |expects_vary: false| shared_examples 'cacheable response' do |expects_vary: false|
it 'does not set cookies' do it 'sets correct cache and vary headers and does not set cookies or session' do
expect(response.cookies).to be_empty expect(response.cookies).to be_empty
expect(response.headers['Set-Cookies']).to be_nil expect(response.headers['Set-Cookies']).to be_nil
end
it 'does not set sessions' do
expect(session).to be_empty expect(session).to be_empty
end
if expects_vary expect(response.headers['Vary']).to include(expects_vary) if expects_vary
it 'returns Vary header' do
expect(response.headers['Vary']).to include(expects_vary)
end
end
it 'returns public Cache-Control header' do
expect(response.headers['Cache-Control']).to include('public') expect(response.headers['Cache-Control']).to include('public')
end end
end end