From f868fcb154634134934d338197ba295c50e57316 Mon Sep 17 00:00:00 2001 From: Akihiko Odaki Date: Tue, 30 May 2017 01:05:01 +0900 Subject: [PATCH] Spec Settings::Exports (#3384) * Spec output of Settings::Exports::BlockedAccountsController * Spec output of Settings::Exports::FollowingAccountsController * Spec output of Settings::Exports::MutedAccountsController * Spec Settings::Exports::BaseController This commit removes duplicate specs in classes inheriting Settings::Exports::BaseController as well. --- .../settings/exports/base_controller_spec.rb | 29 +++++++++++++++++++ .../blocked_accounts_controller_spec.rb | 12 ++++---- .../following_accounts_controller_spec.rb | 12 ++++---- .../exports/muted_accounts_controller_spec.rb | 12 ++++---- 4 files changed, 44 insertions(+), 21 deletions(-) create mode 100644 spec/controllers/settings/exports/base_controller_spec.rb diff --git a/spec/controllers/settings/exports/base_controller_spec.rb b/spec/controllers/settings/exports/base_controller_spec.rb new file mode 100644 index 0000000000..c924d449ae --- /dev/null +++ b/spec/controllers/settings/exports/base_controller_spec.rb @@ -0,0 +1,29 @@ +# frozen_string_literal: true + +require 'rails_helper' + +describe Settings::Exports::BaseController do + controller do + def export_data + @export.account.username + end + end + + describe 'GET #index' do + it 'returns a csv of the exported data when signed in' do + user = Fabricate(:user) + sign_in user + get :index, format: :csv + + expect(response).to have_http_status(:success) + expect(response.content_type).to eq 'text/csv' + expect(response.headers['Content-Disposition']).to eq 'attachment; filename="base.csv"' + expect(response.body).to eq user.account.username + end + + it 'returns unauthorized when not signed in' do + get :index, format: :csv + expect(response).to have_http_status(:unauthorized) + end + end +end diff --git a/spec/controllers/settings/exports/blocked_accounts_controller_spec.rb b/spec/controllers/settings/exports/blocked_accounts_controller_spec.rb index e79a6729a6..5ff41b7fcd 100644 --- a/spec/controllers/settings/exports/blocked_accounts_controller_spec.rb +++ b/spec/controllers/settings/exports/blocked_accounts_controller_spec.rb @@ -3,17 +3,15 @@ require 'rails_helper' describe Settings::Exports::BlockedAccountsController do render_views - before do - sign_in Fabricate(:user), scope: :user - end - describe 'GET #index' do it 'returns a csv of the blocking accounts' do + user = Fabricate(:user) + user.account.block!(Fabricate(:account, username: 'username', domain: 'domain')) + + sign_in user, scope: :user get :index, format: :csv - expect(response).to have_http_status(:success) - expect(response.content_type).to eq 'text/csv' - expect(response.headers['Content-Disposition']).to eq 'attachment; filename="blocked_accounts.csv"' + expect(response.body).to eq "username@domain\n" end end end diff --git a/spec/controllers/settings/exports/following_accounts_controller_spec.rb b/spec/controllers/settings/exports/following_accounts_controller_spec.rb index 503455feaa..786769d245 100644 --- a/spec/controllers/settings/exports/following_accounts_controller_spec.rb +++ b/spec/controllers/settings/exports/following_accounts_controller_spec.rb @@ -3,17 +3,15 @@ require 'rails_helper' describe Settings::Exports::FollowingAccountsController do render_views - before do - sign_in Fabricate(:user), scope: :user - end - describe 'GET #index' do it 'returns a csv of the following accounts' do + user = Fabricate(:user) + user.account.follow!(Fabricate(:account, username: 'username', domain: 'domain')) + + sign_in user, scope: :user get :index, format: :csv - expect(response).to have_http_status(:success) - expect(response.content_type).to eq 'text/csv' - expect(response.headers['Content-Disposition']).to eq 'attachment; filename="following_accounts.csv"' + expect(response.body).to eq "username@domain\n" end end end diff --git a/spec/controllers/settings/exports/muted_accounts_controller_spec.rb b/spec/controllers/settings/exports/muted_accounts_controller_spec.rb index 37c3a0fcfe..f42d7881ed 100644 --- a/spec/controllers/settings/exports/muted_accounts_controller_spec.rb +++ b/spec/controllers/settings/exports/muted_accounts_controller_spec.rb @@ -3,17 +3,15 @@ require 'rails_helper' describe Settings::Exports::MutedAccountsController do render_views - before do - sign_in Fabricate(:user), scope: :user - end - describe 'GET #index' do it 'returns a csv of the muting accounts' do + user = Fabricate(:user) + user.account.mute!(Fabricate(:account, username: 'username', domain: 'domain')) + + sign_in user, scope: :user get :index, format: :csv - expect(response).to have_http_status(:success) - expect(response.content_type).to eq 'text/csv' - expect(response.headers['Content-Disposition']).to eq 'attachment; filename="muted_accounts.csv"' + expect(response.body).to eq "username@domain\n" end end end