Matt Jankowski
cf86cc68b7
Fix RSpec/InferredSpecType cop ( #24736 )
2023-05-04 05:49:53 +02:00
Matt Jankowski
8dec215a57
Fix RSpec/ContextWording cop ( #24739 )
2023-05-04 05:49:08 +02:00
Matt Jankowski
2cd141b65f
Fix RSpec/MultipleSubjects cop ( #24738 )
2023-05-04 05:48:35 +02:00
Matt Jankowski
e8537a3a01
Fix Performance/CollectionLiteralInLoop cop ( #24819 )
2023-05-04 05:33:55 +02:00
Matt Jankowski
a8aad4a45a
Fix Performance/RedundantMerge cop ( #24817 )
2023-05-04 05:25:43 +02:00
Matt Jankowski
916f204ec1
Fix Lint/ConstantDefinitionInBlock cop ( #24763 )
2023-05-03 10:32:30 +02:00
Matt Jankowski
b7e49e1a70
Fix Performance/MethodObjectAsBlock cop ( #24798 )
2023-05-03 10:30:54 +02:00
Matt Jankowski
fdd7fc23c2
Fix Performance/RedundantEqualityComparisonBlock cop ( #24799 )
2023-05-03 10:30:10 +02:00
Matt Jankowski
53682a7b4f
Fix Performance/DeletePrefix cop ( #24796 )
2023-05-02 21:07:45 +02:00
Matt Jankowski
8ecd2fbe07
Fix Lint/EmptyClass cop ( #24795 )
2023-05-02 21:06:51 +02:00
Matt Jankowski
c886971abb
Fix Rails/DeprecatedActiveModelErrorsMethods cop ( #24742 )
2023-05-02 18:39:22 +02:00
Matt Jankowski
ec265b7d8a
Fix Rails/ActiveRecordCallbacksOrder cop ( #24689 )
2023-05-02 18:23:35 +02:00
Matt Jankowski
7a843ed550
Extract AccountSearch concern from Account ( #24716 )
2023-05-02 18:21:36 +02:00
Matt Jankowski
4d1f9d4278
Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method ( #24741 )
2023-05-02 18:16:07 +02:00
Matt Jankowski
3030a8b458
Fix Performance/TimesMap cop ( #24789 )
2023-05-02 18:07:16 +02:00
Matt Jankowski
276a0f7ff9
Fix Performance/Count cop ( #24793 )
2023-05-02 18:06:43 +02:00
Matt Jankowski
621e53f8fc
Fix Performance/Sum cop ( #24788 )
2023-05-02 16:10:40 +02:00
Matt Jankowski
182bb4595f
Fix Lint/DuplicateBranch cop ( #24766 )
2023-05-02 12:57:11 +02:00
Claire
abce7cf2b9
Rewrite import feature ( #21054 )
2023-05-02 12:08:48 +02:00
Matt Jankowski
ae34d806be
Fix RSpec/BeforeAfterAll cop ( #24737 )
2023-05-01 04:16:08 +09:00
Matt Jankowski
bdbc9d0036
Fix Rails/CompactBlank cop ( #24690 )
2023-04-30 14:07:21 +02:00
Matt Jankowski
2a78b65bfd
Fix Rails/I18nLocaleAssignment cop ( #24693 )
2023-04-30 14:07:03 +02:00
Matt Jankowski
e9e394fe57
Fix Rails/InverseOf cop ( #24732 )
2023-04-30 14:06:53 +02:00
Matt Jankowski
8a813615b0
Fix Rails/Output cop ( #24687 )
2023-04-30 06:48:16 +02:00
Matt Jankowski
78f29479ab
Fix Rails/Present cop ( #24688 )
2023-04-30 06:47:50 +02:00
Matt Jankowski
ba0a49b7f6
Fix Rails/ContentTag cop ( #24691 )
2023-04-30 06:47:15 +02:00
Matt Jankowski
390aa577e7
Fix Rails/ActionOrder cop ( #24692 )
2023-04-30 06:46:39 +02:00
Matt Jankowski
16e08228df
Fix Rails/SquishedSQLHeredocs cop ( #24694 )
2023-04-30 06:43:50 +02:00
Matt Jankowski
807ada7b39
Fix Rails/HttpPositionalArguments cop ( #24699 )
2023-04-30 06:43:28 +02:00
Matt Jankowski
f9fcde8205
Add pending spec for User.those_who_can ( #24724 )
2023-04-29 22:03:36 +02:00
Claire
498de92bc8
Merge branch 'main' into glitch-soc/merge-upstream
...
Conflicts:
- `.github/dependabot.yml`:
Updated upstream, removed in glitch-soc to disable noise.
Kept removed.
- `CODE_OF_CONDUCT.md`:
Upstream updated to a new version of the covenant, but I have not read it
yet, so kept unchanged.
- `Gemfile.lock`:
Not a real conflict, one upstream dependency updated textually too close to
the glitch-soc only `hcaptcha` dependency.
Applied upstream changes.
- `app/controllers/admin/base_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/application_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/disputes/base_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/relationships_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/statuses_cleanup_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/helpers/application_helper.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/javascript/mastodon/features/compose/components/compose_form.jsx`:
Upstream added a highlight animation for onboarding, while we changed the
max character limit.
Applied our local changes on top of upstream's new version.
- `app/views/layouts/application.html.haml`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `stylelint.config.js`:
Upstream added ignore paths, glitch-soc had extra ignore paths.
Added the same paths as upstream.
2023-04-29 10:44:56 +02:00
Nick Schonning
519ae8c0c6
Drop EOL Ruby 2.7 ( #24237 )
2023-04-27 01:46:18 +02:00
Nick Schonning
b36ccb2fac
Autofix Rubocop RSpec/MatchArray ( #24675 )
2023-04-26 21:29:36 +02:00
Nick Schonning
16cc6bc400
Autofix Rubocop RSpec/MatchArray ( #24050 )
2023-04-26 20:21:54 +02:00
Nick Schonning
28d554cc49
Autofix Rubocop Rails/ResponseParsedBody ( #24051 )
2023-04-26 17:25:07 +02:00
Matt Jankowski
f01a643897
Remove instance variables from helper usage ( #24203 )
2023-04-23 22:35:54 +02:00
Nick Schonning
91f0da8563
Autofix Rubocop Style/NumericLiterals ( #24468 )
2023-04-23 22:30:07 +02:00
Eugen Rochko
3ca64638d4
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2023-04-19 16:07:29 +02:00
Claire
0cbf19affd
Fix most rubocop issues ( #2165 )
...
* Run rubocop --autocorrect on app/, config/ and lib/, also manually fix some remaining style issues
* Run rubocop --autocorrect-all on db/
* Run rubocop --autocorrect-all on `spec/` and fix remaining issues
2023-04-09 11:25:30 +02:00
Nick Schonning
5f1a0f550b
Autofix Rubocop Rails/IgnoredColumnsAssignment ( #23761 )
2023-03-31 15:07:22 +02:00
Nick Schonning
2a0d2453b0
Autofix Rubocop Style/IdenticalConditionalBranches ( #24322 )
2023-03-31 09:33:52 +02:00
Nick Schonning
718cdb0286
Enable Rubocop Metrics/BlockLength with Excludes ( #24260 )
2023-03-31 09:33:25 +02:00
Eugen Rochko
c75fccf033
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-03-30 14:44:00 +02:00
Nick Schonning
2ed77774f7
Exclude files for Rubocop Metrics/ClassLength ( #24213 )
2023-03-23 23:19:41 +01:00
Matt Jankowski
7a82026971
Remove references to non-existent actions ( #24183 )
2023-03-20 20:03:44 +01:00
Vyr Cossont
d1b3f02926
Webhooks for local status.create, status.update, account.update ( #24133 )
2023-03-19 07:47:54 +01:00
Nick Schonning
8d05167e5f
Include config/ and update all rubcop deps ( #23963 )
2023-03-17 10:13:28 +01:00
Nick Schonning
c2821e2aa3
Ignore additional Style/OptionalBooleanParameter ( #24138 )
2023-03-16 23:07:25 +01:00
Matt Jankowski
10a4c16256
Roll back unintentionally activated rubocop rules ( #24132 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
2023-03-16 22:24:01 +01:00
Christian Schmidt
7583523bf0
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2023-03-16 11:07:24 +01:00
Nick Schonning
8f638799ec
Regen rubocop-todo without Max shadowing ( #24076 )
2023-03-16 12:31:08 +09:00
Nick Schonning
0717d1b058
Autofix Rubocop Style/RedundantArgument ( #23798 )
2023-03-16 10:34:00 +09:00
Nick Schonning
6d0a49f4a4
Autofix Rubocop Style/PreferredHashMethods ( #23851 )
2023-03-16 01:36:37 +01:00
Nick Schonning
12cbdf36a9
Enable Rubocop Performance/DeleteSuffix ( #24077 )
2023-03-13 00:03:07 +01:00
Nick Schonning
7f17a44a6b
Enable RSpec/FilePath ( #23965 )
2023-03-10 16:32:37 +01:00
Matt Jankowski
7a8257b638
Coverage improvement round-out following up previous work ( #23987 )
2023-03-10 13:33:30 +01:00
Matt Jankowski
c5c1e07555
Serializers spec coverage ( #24017 )
2023-03-10 12:12:51 +01:00
Claire
370cff9a5d
Disable Style/SymbolArray ( #23921 )
2023-03-03 22:55:43 +01:00
Nick Schonning
19be243493
Autofix Rubocop Style/HashConversion ( #23852 )
2023-02-28 22:59:19 +09:00
Matt Jankowski
c759d6f31d
Remove unused HTML Validator ( #23866 )
2023-02-24 20:06:32 +01:00
Nick Schonning
1cdd7d6c8f
Rename ActivityPub Serializer Specs ( #23844 )
2023-02-23 23:17:48 +01:00
Nick Schonning
43a3812265
Fix mispelled spec filenames ( #23834 )
2023-02-23 11:28:56 +01:00
Nick Schonning
4f6ad6475e
Autofix Rubocop Rails/Blank ( #23765 )
2023-02-22 09:57:56 +09:00
Nick Schonning
eb6991cee1
Autofix Rubocop Rails/RootPathnameMethods ( #23760 )
2023-02-22 09:57:15 +09:00
Nick Schonning
247bf6e812
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2023-02-22 09:54:36 +09:00
Nick Schonning
a0e4d69c12
Autofix Rubocop Rails/FindById ( #23762 )
2023-02-21 10:21:48 +09:00
Nick Schonning
25cf99e513
Autofix Rubocop Security/IoMethods ( #23757 )
2023-02-21 03:21:19 +09:00
Nick Schonning
eed0829d3f
Autofix Rubocop Rails/WhereEquals ( #23759 )
2023-02-21 03:20:56 +09:00
Nick Schonning
dd63a919f0
Autofix Rubocop Style/RescueStandardError ( #23745 )
2023-02-20 11:01:20 +01:00
Nick Schonning
9376fccf91
Autofix Rubocop Style/SymbolProc ( #23742 )
2023-02-20 07:58:46 +01:00
Nick Schonning
9b3be79cb5
Autofix Rubocop Style/FormatString ( #23743 )
2023-02-20 07:58:33 +01:00
Nick Schonning
e6312104c7
Autofix Rubocop remaining Layout rules ( #23679 )
2023-02-20 06:58:28 +01:00
Nick Schonning
c08d9e5e5c
Autofix Rubocop Style/UnpackFirst ( #23741 )
2023-02-20 06:51:43 +01:00
Nick Schonning
a4cbfac4d9
Autofix Rubocop RSpec/BeEq ( #23740 )
2023-02-20 06:14:50 +01:00
Nick Schonning
c0f0c42326
Audofix Rubocop Style/WordArray ( #23739 )
2023-02-20 06:14:10 +01:00
Nick Schonning
754c417e29
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2023-02-20 13:24:14 +09:00
Nick Schonning
a1e0384fc5
Enable Rubocop RSpec/ExpectActual ( #23720 )
2023-02-20 05:00:59 +01:00
Nick Schonning
ac56c3971b
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2023-02-20 05:00:48 +01:00
Nick Schonning
448f0929a7
Autofix Rubocop Rails/EnumHash ( #23737 )
2023-02-20 05:00:36 +01:00
Nick Schonning
06f8de2e34
Autofix Rubocop Style/ExplicitBlockArgument ( #23704 )
2023-02-20 11:18:08 +09:00
Nick Schonning
0d47dee648
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2023-02-20 11:17:41 +09:00
Nick Schonning
ae51248ffe
Enable Rubocop HTTP status rules ( #23717 )
2023-02-20 11:16:40 +09:00
Nick Schonning
f6c4699d73
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2023-02-20 02:46:00 +01:00
Nick Schonning
181617e3d9
Autofix Rubocop Lint/UnusedBlockArgument ( #23712 )
2023-02-20 02:45:50 +01:00
Nick Schonning
a25f6522da
Enable Rubocop RSpec/NotToNot ( #23723 )
2023-02-20 02:33:27 +01:00
Nick Schonning
1de4bdbaf4
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2023-02-20 02:32:10 +01:00
Nick Schonning
b8f17330ea
Autofix Rubocop Rails/Pluck ( #23730 )
2023-02-20 02:28:40 +01:00
Nick Schonning
483fabc53f
Autofix Rubocop Rails/RedundantForeignKey ( #23731 )
2023-02-20 02:19:40 +01:00
Nick Schonning
46d56d2403
Autofix Rubocop Style/EmptyMethod ( #23732 )
2023-02-20 02:18:54 +01:00
Nick Schonning
e08a42e1d7
Autofix Rubocop RSpec/EmptyLineAfterHook ( #23718 )
2023-02-19 14:54:34 +09:00
Nick Schonning
be1ec56c6d
Autofix Rubocop Style/StringLiterals ( #23695 )
2023-02-19 07:38:14 +09:00
Nick Schonning
28b19386c1
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2023-02-19 07:17:59 +09:00
Nick Schonning
bfc66a0454
Autofix Rubocop Style/EmptyLambdaParameter ( #23705 )
2023-02-19 07:12:06 +09:00
Nick Schonning
a63cb79201
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2023-02-19 07:10:19 +09:00
Nick Schonning
49f1168050
Autofix Rubocop Style/RedundantBegin ( #23703 )
2023-02-19 07:09:40 +09:00
Nick Schonning
e9074c3eb5
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2023-02-19 07:00:17 +09:00
Nick Schonning
2e4833b246
Autofix Rubocop RSpec/Capybara/FeatureMethods ( #23708 )
2023-02-19 06:59:00 +09:00
Nick Schonning
6988b04ec7
Autofix Rubocop Style/TrailingCommaInArrayLiteral ( #23692 )
2023-02-19 06:54:30 +09:00
Nick Schonning
4dc470fbee
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2023-02-18 23:33:41 +09:00
Nick Schonning
a2129d336a
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2023-02-18 12:47:37 +01:00