Commit Graph

146 Commits (94cc707ab398339dfe74472300056876fac81856)

Author SHA1 Message Date
Matt Jankowski cca19f5fbb
Use the `Admin::ActionLog` fabricator in admin/action_logs spec () 2023-12-04 12:56:28 +00:00
Matt Jankowski 19ad51253d
Prevent triple-subject run in admin/domain_blocks spec () 2023-12-04 09:02:40 +00:00
Matt Jankowski d848d8d87c
Add helper methods for domains allow and export blocks files () 2023-12-04 08:52:21 +00:00
Matt Jankowski b751078fcd
Eliminate double subject call in admin/ controller specs () 2023-12-01 10:38:15 +00:00
Matt Jankowski 32e19e3af6
Reduce `.times` usage in request and controller specs () 2023-11-21 13:05:59 +00:00
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop () 2023-11-14 14:52:59 +00:00
Matt Jankowski 49ba5a9f94
Use `hash_including` to check `AccountFilter` setup in `admin/accounts` controller spec () 2023-11-13 16:01:24 +00:00
Matt Jankowski dc0bf87090
Remove unused before block from settings/branding spec () 2023-11-07 15:19:17 +00:00
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop () 2023-11-07 09:46:28 +00:00
Matt Jankowski beee9ea991
Fix `RSpec/LetSetup` cop in spec/controllers/admin area () 2023-10-31 08:22:19 +00:00
Matt Jankowski 2e6bf60f15
Use `deliveries.size` in mailer-related examples in controller specs () 2023-10-27 15:33:52 +00:00
Matt Jankowski 9f218c9924
Refactor appeal partial to avoid brakeman XSS warning () 2023-10-19 17:25:54 +02:00
Matt Jankowski 708299bb0d
Misc coverage improvements for `Admin::` and `Settings::` controllers () 2023-10-16 17:20:28 +02:00
Claire b83e487502
Fix moderator rights inconsistencies () 2023-09-06 16:40:19 +02:00
Matt Jankowski c75df62ccc
Fix `RSpec/SubjectDeclaration` cop () 2023-07-12 09:49:33 +02:00
Matt Jankowski 05f9e39b32
Fix `RSpec/VerifiedDoubles` cop () 2023-06-22 14:55:22 +02:00
Matt Jankowski 38433ccd0b
Reduce `Admin::Reports::Actions` spec db activity () 2023-06-22 14:53:13 +02:00
Claire 602c458ab6
Add finer permission requirements for managing webhooks () 2023-06-22 14:52:25 +02:00
Claire fd23f50243
Fix wrong view being displayed when a webhook fails validation () 2023-06-20 18:15:35 +02:00
Matt Jankowski 4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix `RSpec/IndexedLet` cop () 2023-06-14 16:44:37 +02:00
Matt Jankowski 6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop () 2023-06-06 15:51:42 +02:00
Matt Jankowski 1e243e2df7
Misc spec coverage for `Admin::` area controllers () 2023-06-06 13:57:00 +02:00
Claire e9385e93e9
Add a confirmation screen when suspending a domain () 2023-06-01 09:37:38 +02:00
Matt Jankowski 8b1bfaed3e
Add specs for admin/webhooks CRUD actions () 2023-05-31 15:23:49 +02:00
Matt Jankowski 665bb237a8
Increase spec coverage for controllers - admin/ip_blocks, admin/relays, admin/rules () 2023-05-31 10:23:32 +02:00
Matt Jankowski d2e5430d4a
Fix RSpec/ExpectChange cop () 2023-05-24 11:23:40 +02:00
Matt Jankowski 2877c80dbc
Add specs for admin/announcements CRUD actions () 2023-05-23 10:03:51 +02:00
Nick Schonning 99e2e9b81f
Fix minor typos in comments and spec names () 2023-05-19 17:13:29 +02:00
Matt Jankowski 2c2d924942
Fix RSpec/RepeatedExampleGroupDescription cop ()
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-05-12 12:25:32 +02:00
Matt Jankowski a610a02d4f
Fix RSpec/ScatteredSetup cop () 2023-05-11 10:32:09 +02:00
Nick Schonning da3bd913ae
Autofix Rubocop Style/HashSyntax () 2023-05-04 05:54:26 +02:00
Matt Jankowski c97b611b6b
Fix RSpec/InferredSpecType cop () 2023-05-04 05:49:53 +02:00
Matt Jankowski 710745e16b
Fix RSpec/ContextWording cop () 2023-05-04 05:49:08 +02:00
Nick Schonning a3393d0d07
Autofix Rubocop RSpec/MatchArray () 2023-04-26 20:21:54 +02:00
Eugen Rochko e98c86050a
Refactor `Cache-Control` and `Vary` definitions () 2023-04-19 16:07:29 +02:00
Matt Jankowski 42ddc45133
Admin controllers specs () 2023-03-04 17:13:28 +01:00
Claire 3f52e717fa
Add tests for moderation actions without custom text () 2023-03-03 20:50:46 +01:00
Nick Schonning 6bd7003799
Fix mispelled spec filenames () 2023-02-23 11:28:56 +01:00
Nick Schonning 84cc805cae
Enable Style/FrozenStringLiteralComment for specs () 2023-02-22 09:55:31 +09:00
Nick Schonning 35d032500b
Autofix Rubocop Security/IoMethods () 2023-02-21 03:21:19 +09:00
Nick Schonning 5116347eb7
Autofix Rubocop RSpec/BeEq () 2023-02-20 06:14:50 +01:00
Nick Schonning 4552685f6b
Autofix Rubocop RSpec/LeadingSubject () 2023-02-20 13:24:14 +09:00
Nick Schonning 38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject () 2023-02-20 05:00:48 +01:00
Nick Schonning 5179c47087
Autofix Rubocops RSpec/ScatteredLet () 2023-02-20 11:17:41 +09:00
Nick Schonning aef0051fd0
Enable Rubocop HTTP status rules () 2023-02-20 11:16:40 +09:00
Nick Schonning bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject () 2023-02-20 02:46:00 +01:00
Nick Schonning 65ba0d92ef
Enable Rubocop RSpec/NotToNot () 2023-02-20 02:33:27 +01:00
Nick Schonning 81ad6c2e39
Autofix Rubocop Style/StringLiterals () 2023-02-19 07:38:14 +09:00
Nick Schonning 3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet () 2023-02-19 07:10:19 +09:00
Nick Schonning 5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral () 2023-02-18 23:33:41 +09:00