Sign-up form password field char limit inconsistency #22

Open
opened 2022-11-25 06:05:46 +00:00 by simonxciv · 4 comments

When signing up via /auth/sign_up, the password field has maxlength="72" set, however the password confirmation field does not. When filled with a password manager defaulting to a > 72 char password, the password gets truncated in the first field and not the second, resulting in a mismatch that's not evident until the submission fails.

Some client-side validation + adding maxlength attribute on the confirmation field would fix this 😃

When signing up via /auth/sign_up, the password field has `maxlength="72"` set, however the password confirmation field does not. When filled with a password manager defaulting to a > 72 char password, the password gets truncated in the first field and not the second, resulting in a mismatch that's not evident until the submission fails. Some client-side validation + adding maxlength attribute on the confirmation field would fix this 😃
Rin added the
type/bug
area/ux
labels 2022-11-25 06:06:24 +00:00
kouhai was assigned by Rin 2022-11-25 06:06:44 +00:00
Rin self-assigned this 2022-11-25 06:06:44 +00:00

File at fault is app/views/auth/passwords/edit.html.haml. Working on a fix.

File at fault is `app/views/auth/passwords/edit.html.haml`. Working on a fix.

Side note @ariadne , do you know if there's any technical reason we're limiting password length to 72 characters?

Side note @ariadne , do you know if there's any technical reason we're limiting password length to 72 characters?

No reason for the limit tbh, the password is hashed.

No reason for the limit tbh, the password is hashed.

https://github.com/mastodon/mastodon/issues/13152 screams
Okay, this will require a hair more thought.

https://github.com/mastodon/mastodon/issues/13152 *screams* Okay, this will require a hair more thought.
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: treehouse/mastodon#22
There is no content yet.