Sign-up form password field char limit inconsistency #22
Labels
No Label
area/i18n
area/infrastructure
area/moderation & safety
area/ux
priority/1.high
priority/2.medium
priority/3.low
tag/upstream issue
tag/duplicate
tag/help wanted
tag/invalid
tag/won't fix
type/bug
type/enhancement
type/question
No Milestone
No project
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: treehouse/mastodon#22
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
When signing up via /auth/sign_up, the password field has
maxlength="72"
set, however the password confirmation field does not. When filled with a password manager defaulting to a > 72 char password, the password gets truncated in the first field and not the second, resulting in a mismatch that's not evident until the submission fails.Some client-side validation + adding maxlength attribute on the confirmation field would fix this 😃
File at fault is
app/views/auth/passwords/edit.html.haml
. Working on a fix.Side note @ariadne , do you know if there's any technical reason we're limiting password length to 72 characters?
No reason for the limit tbh, the password is hashed.
https://github.com/mastodon/mastodon/issues/13152 screams
Okay, this will require a hair more thought.