Refactor generate-sku-list.py

generate-sku-list.py

@@ -1,37 +1,50 @@
 #!/usr/bin/env python3
 
-import os
-import sys
 import json
 
-variants = []
+def format_skus(sku_ids, suffix):
-sku_ids = {}
+    sku_ids_formatted = ""
+    for sku in sku_ids[suffix]:
+        if sku_ids_formatted == "":
+            sku_ids_formatted = sku
+        else:
+            sku_ids_formatted = f"{sku_ids_formatted}|{sku}"
+    return sku_ids_formatted
 
+def load_project_config():
     with open("project-config.json", "r") as project:
-    p_json = json.load(project)
+        project_json = json.load(project)
-
+    return project_json['chromeos']['configs']
-configs = p_json['chromeos']['configs']
 
+def select_variant(configs):
+    variants = []
     print("Variants:")
     for config in configs:
-    variant = config['name']
+        if config['name'] in variants:
-    if not variant in variants:
+            continue
-        variants.append(variant)
+        variants.append(config['name'])
-        print(variant)
+        print(config['name'])
-
+    return input("Choose a variant: ")
-variant = input("Choose a variant: ")
 
+def parse_sku_ids(configs, variant):
+    sku_ids = {}
     for config in configs:
-    if config['audio']['main']['cras-config-dir'] == variant:
+        if variant not in config['audio']['main']['cras-config-dir']:
-        if not config['audio']['main']['ucm-suffix'] in sku_ids:
+            continue
+        if config['audio']['main']['ucm-suffix'] not in sku_ids:
             sku_ids[config['audio']['main']['ucm-suffix']] = []
         sku_ids[config['audio']['main']['ucm-suffix']].append(config['identity']['sku-id'])
+    return sku_ids
 
+def print_sku_id_list(sku_ids):
     for suffix in sku_ids:
-    suffixes_formatted = ""
+        sku_ids_formatted = format_skus(sku_ids, suffix)
-    for sku in sku_ids[suffix]:
+        print(f"{suffix}: {sku_ids_formatted}")
-        if suffixes_formatted == "":
+
-            suffixes_formatted = str(sku)
+def main():
-        else:
+    configs = load_project_config()
-            suffixes_formatted = f"{suffixes_formatted}|{str(sku)}"
+    variant = select_variant(configs)
-    print(f"{suffix}: {suffixes_formatted}")
+    sku_ids = parse_sku_ids(configs, variant)
+    print_sku_id_list(sku_ids)
+
+main()