From bbd8bf46fc6eb9cc95fb817bbec1941e0bed0604 Mon Sep 17 00:00:00 2001
From: Nguyen Tran Hau <hauvipapro@gmail.com>
Date: Tue, 11 May 2021 11:43:26 +0700
Subject: [PATCH] feat: skip empty commit

---
 internal/convention/option.go | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/internal/convention/option.go b/internal/convention/option.go
index 50d82e8..7c52b5b 100644
--- a/internal/convention/option.go
+++ b/internal/convention/option.go
@@ -1,7 +1,6 @@
 package convention
 
 import (
-	"errors"
 	"fmt"
 	"regexp"
 	"strings"
@@ -10,21 +9,19 @@ import (
 	"github.com/haunt98/clock"
 )
 
-var (
-	ErrEmptyCommit = errors.New("empty commit")
-
-	headerRegex = regexp.MustCompile(`(?P<type>[a-zA-Z]+)(?P<scope>\([a-zA-Z]+\))?(?P<attention>!)?:\s(?P<description>.+)`)
-)
+var headerRegex = regexp.MustCompile(`(?P<type>[a-zA-Z]+)(?P<scope>\([a-zA-Z]+\))?(?P<attention>!)?:\s(?P<description>.+)`)
 
 type OptionFn func(*Commit) error
 
 func GetRawHeader(gitCommit git.Commit) OptionFn {
 	return func(c *Commit) error {
+		// Skip empty commit
+		if gitCommit.Message == "" {
+			return nil
+		}
+
 		message := strings.TrimSpace(gitCommit.Message)
 		messages := strings.Split(message, "\n")
-		if len(messages) == 0 {
-			return ErrEmptyCommit
-		}
 
 		c.RawHeader = messages[0]