From 31724133f19520fd80ab8cc358363df50297529e Mon Sep 17 00:00:00 2001 From: Hau Nguyen Date: Sat, 23 Jul 2022 23:16:11 +0700 Subject: [PATCH] refactor: move reader close fn inside main scope --- main.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/main.go b/main.go index f33cbb1..5d8990e 100644 --- a/main.go +++ b/main.go @@ -29,9 +29,11 @@ func runGoTest() int { // Output pipe and error pipe outReader, outWriter := io.Pipe() + defer outReader.Close() defer outWriter.Close() errReader, errWriter := io.Pipe() + defer errReader.Close() defer errWriter.Close() cmd.Stdout = outWriter @@ -47,9 +49,7 @@ func runGoTest() int { return 0 } -func colorOutputReader(reader io.ReadCloser) { - defer reader.Close() - +func colorOutputReader(reader io.Reader) { scanner := bufio.NewScanner(reader) for scanner.Scan() { @@ -82,9 +82,7 @@ func colorOutputReader(reader io.ReadCloser) { } } -func colorErrorReader(reader io.ReadCloser) { - defer reader.Close() - +func colorErrorReader(reader io.Reader) { scanner := bufio.NewScanner(reader) for scanner.Scan() {