From b17a39b0dd5a16c36fba2819ee9b38592c00bc1f Mon Sep 17 00:00:00 2001 From: Hau Nguyen Date: Tue, 17 Jan 2023 11:53:49 +0700 Subject: [PATCH] feat: ignore empty imports --- internal/imports/formatter.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/internal/imports/formatter.go b/internal/imports/formatter.go index 2fe4191..66731b7 100644 --- a/internal/imports/formatter.go +++ b/internal/imports/formatter.go @@ -32,6 +32,7 @@ var ( ErrNotGoFile = errors.New("not go file") ErrGoGeneratedFile = errors.New("go generated file") ErrAlreadyFormatted = errors.New("already formatted") + ErrEmptyImport = errors.New("empty import") ErrGoModNotExist = errors.New("go mod not exist") ErrGoModEmptyModule = errors.New("go mod empty module") ) @@ -201,16 +202,11 @@ func (ft *Formatter) formatFile(path string) error { return nil } -// Copy from goimports, gofumpt, goimports-reviser -// First parse ast -// -// # Then group imports -// -// # Then format imports -// -// # Then update ast decls -// -// Then print ast +// Copy from goimports, gofumpt, goimports-reviser. +// First parse ast. +// Then group imports. +// Then format imports. +// Then print. func (ft *Formatter) formatImports( path string, pathBytes []byte, @@ -238,6 +234,9 @@ func (ft *Formatter) formatImports( if err != nil { return nil, fmt.Errorf("decorator: failed to parse file [%s]: %w", path, err) } + if len(dstFile.Imports) == 0 { + return nil, ErrEmptyImport + } ft.logDSTImportSpecs("formatImports: dstImportSpecs", dstFile.Imports) groupedDSTImportSpecs, err := ft.groupDSTImportSpecs( @@ -406,5 +405,6 @@ func (ft *Formatter) moduleName(path string) (string, error) { func (ft *Formatter) isIgnoreError(err error) bool { return errors.Is(err, ErrNotGoFile) || errors.Is(err, ErrGoGeneratedFile) || - errors.Is(err, ErrAlreadyFormatted) + errors.Is(err, ErrAlreadyFormatted) || + errors.Is(err, ErrEmptyImport) }