From bf054e6b17cf53ef3030c6cc28fce490fffa14e3 Mon Sep 17 00:00:00 2001 From: Hau Nguyen Date: Sun, 25 Dec 2022 18:02:58 +0700 Subject: [PATCH] chore: fix typo --- docs/2022-12-25-go-test-asap.html | 4 ++-- posts/2022-12-25-go-test-asap.md | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/2022-12-25-go-test-asap.html b/docs/2022-12-25-go-test-asap.html index fe09c85..72c6e08 100644 --- a/docs/2022-12-25-go-test-asap.html +++ b/docs/2022-12-25-go-test-asap.html @@ -78,7 +78,7 @@ func (s *ServiceSuite) TestUpload() { }) } } -

Looks good right?
Be careful with this.
It can go from 0 to 100 ugly real quick.

What if req is a struct with many fields?
So in each test case you need to set up req.
They are almose the same, but with some error case you must alter req.
It's easy to be wrong here (typing maybe ?).

tests := []struct{
+

Looks good right?
Be careful with this.
It can go from 0 to 100 ugly real quick.

What if req is a struct with many fields?
So in each test case you need to set up req.
They are almost the same, but with some error case you must alter req.
It's easy to be init with wrong value here (typing maybe ?).
Also all req looks similiar, kinda duplicated.

tests := []struct{
         name string
         req Request
         verifyErr error
@@ -180,5 +180,5 @@ func (s *ServiceSuite) TestUpload() {
 
     // ...
 }
-

So if request change fields or more dependencies, I need to update success case, and maybe add error case if need.

Same idea but still with table, you can find here Functional table-driven tests in Go - Fatih Arslan

Feel free to ask me via email +

So if request change fields or more dependencies, I need to update success case, and maybe add corresponding error case if need.

Same idea but still with table, you can find here Functional table-driven tests in Go - Fatih Arslan.

Feel free to ask me via email Mastodon \ No newline at end of file diff --git a/posts/2022-12-25-go-test-asap.md b/posts/2022-12-25-go-test-asap.md index 3f1a51a..bab06ed 100644 --- a/posts/2022-12-25-go-test-asap.md +++ b/posts/2022-12-25-go-test-asap.md @@ -134,8 +134,9 @@ It can go from 0 to 100 ugly real quick. What if req is a struct with many fields? So in each test case you need to set up req. -They are almose the same, but with some error case you must alter req. -It's easy to be wrong here (typing maybe ?). +They are almost the same, but with some error case you must alter req. +It's easy to be init with wrong value here (typing maybe ?). +Also all req looks similiar, kinda duplicated. ```go tests := []struct{ @@ -261,6 +262,6 @@ func (s *ServiceSuite) TestUpload() { } ``` -So if request change fields or more dependencies, I need to update success case, and maybe add error case if need. +So if request change fields or more dependencies, I need to update success case, and maybe add corresponding error case if need. -Same idea but still with table, you can find here [Functional table-driven tests in Go - Fatih Arslan](https://arslan.io/2022/12/04/functional-table-driven-tests-in-go/) +Same idea but still with table, you can find here [Functional table-driven tests in Go - Fatih Arslan](https://arslan.io/2022/12/04/functional-table-driven-tests-in-go/).