From a8d468f1ec51b49efe9620c6aef374c57cdc6403 Mon Sep 17 00:00:00 2001 From: Hau Nguyen Date: Fri, 28 Jul 2023 21:53:02 +0700 Subject: [PATCH] chore(qmkasciigen): consistent naming --- cmd/qmkasciigen/main.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/cmd/qmkasciigen/main.go b/cmd/qmkasciigen/main.go index 9e1a88e..abcf5b2 100644 --- a/cmd/qmkasciigen/main.go +++ b/cmd/qmkasciigen/main.go @@ -106,13 +106,13 @@ func wrapGetQMKInfo(qmkKeyboardStr, qmkInfoFile string, debug bool) (QMKInfo, er return qmkInfo, nil } -func getQMKInfo(qmkKeyboard string, debug bool) (QMKInfo, error) { - qmkKeyboard = strings.TrimSpace(qmkKeyboard) - if qmkKeyboard == "" { +func getQMKInfo(qmkKeyboardStr string, debug bool) (QMKInfo, error) { + qmkKeyboardStr = strings.TrimSpace(qmkKeyboardStr) + if qmkKeyboardStr == "" { return QMKInfo{}, ErrEmptyQMKInfo } - kbParts := strings.Split(qmkKeyboard, "/") + kbParts := strings.Split(qmkKeyboardStr, "/") for i := 1; i <= len(kbParts); i++ { kb := strings.Join(kbParts[:i], "/") @@ -190,18 +190,18 @@ func wrapGetQMKKeymap(qmkKeyboardStr, qmkKeymapStr, qmkKeymapFile string, debug return qmkKeymap, nil } -func getQMKKeymap(qmkKeyboard, qmkKeymap string, debug bool) (QMKKeymap, error) { - qmkKeyboard = strings.TrimSpace(qmkKeyboard) - qmkKeymap = strings.TrimSpace(qmkKeymap) - if qmkKeyboard == "" || qmkKeymap == "" { +func getQMKKeymap(qmkKeyboardStr, qmkKeymapStr string, debug bool) (QMKKeymap, error) { + qmkKeyboardStr = strings.TrimSpace(qmkKeyboardStr) + qmkKeymapStr = strings.TrimSpace(qmkKeymapStr) + if qmkKeyboardStr == "" || qmkKeymapStr == "" { return QMKKeymap{}, ErrEmptyQMKKeymap } - kbParts := strings.Split(qmkKeyboard, "/") + kbParts := strings.Split(qmkKeyboardStr, "/") for i := 1; i <= len(kbParts); i++ { kb := strings.Join(kbParts[:i], "/") - url := fmt.Sprintf(qmkKeymapURL, kb, qmkKeymap) + url := fmt.Sprintf(qmkKeymapURL, kb, qmkKeymapStr) // nolint:noctx,gosec httpRsp, err := http.Get(url)