yoshie
/
update-go-mod
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: use mutex instead of rwmutex 

See https://github.com/golang/go/wiki/CodeReviewConcurrency#rwmutex
main
sudo pacman -Syu 2023-08-19 00:24:46 +07:00
parent 3d8a57539e
commit 5082bc3cfc
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/cli/action_overlook.go
View File

@ -48,7 +48,7 @@ func (a *action) Overlook(c *cli.Context) error {
mGHRepoData := make(map[string]struct{}) mGHRepoData := make(map[string]struct{})
p := pool.New().WithMaxGoroutines(maxPoolGoroutine) p := pool.New().WithMaxGoroutines(maxPoolGoroutine)
var mMutex sync.RWMutex var mMutex sync.Mutex
var listMutex sync.Mutex var listMutex sync.Mutex
for module := range mapImportedModules { for module := range mapImportedModules {
module := module module := module
@ -65,14 +65,11 @@ func (a *action) Overlook(c *cli.Context) error {
} }
name := parts[0] name := parts[0]
mMutex.RLock() mMutex.Lock()
if _, ok := mGHRepoData[name]; ok { if _, ok := mGHRepoData[name]; ok {
mMutex.RUnlock() mMutex.Unlock()
return return
} }
mMutex.RUnlock()
mMutex.Lock()
mGHRepoData[name] = struct{}{} mGHRepoData[name] = struct{}{}
mMutex.Unlock() mMutex.Unlock()