ariadne
/
libucontext
1
1
Fork 1
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Remaining fixes for Apple Silicon and QEMU #27

Merged
osy merged 3 commits from qemu-support-v2 into master 2021-03-09 02:48:30 +00:00
Conversation 4 Commits 3 Files Changed 18
osy commented 2021-03-09 02:34:19 +00:00 (Migrated from github.com)

These last couple of fixes are needed for the following

  1. Building as a subproject in QEMU
  2. Building for/on M1 Macs
  3. Building for iOS
These last couple of fixes are needed for the following 1. Building as a subproject in QEMU 2. Building for/on M1 Macs 3. Building for iOS
osy commented 2021-03-09 02:37:33 +00:00 (Migrated from github.com)

I still don't know of a good workaround for 9b1d8f01a6 the other way I considered is writing a Python script that generates the .S file but it seems like overkill.

I still don't know of a good workaround for 9b1d8f01a6e99166f9808c79966abe10786de8b6 the other way I considered is writing a Python script that generates the .S file but it seems like overkill.
ariadne commented 2021-03-09 02:47:45 +00:00

i think we can live with it for now. we should raise a bug with the clang project though to have this fixed:

i think we can live with it for now. we should raise a bug with the clang project though to have this fixed:
ariadne approved these changes 2021-03-09 02:48:25 +00:00
osy commented 2021-03-09 03:02:28 +00:00 (Migrated from github.com)

I think having macros expand to a single line is standard but how assemblers handle newline alternative (like ;) is dependent on the assembler: https://stackoverflow.com/questions/27685548/can-i-write-multiple-assembly-instructions-on-the-same-line

Seems like clang's arm64 assembler does not interpret ; as a new line even though clang's x86_64 assembler does...

I think having macros expand to a single line is standard but how assemblers handle newline alternative (like `;`) is dependent on the assembler: https://stackoverflow.com/questions/27685548/can-i-write-multiple-assembly-instructions-on-the-same-line Seems like clang's arm64 assembler does not interpret `;` as a new line even though clang's x86_64 assembler does...
ariadne commented 2021-03-09 18:18:27 +00:00

yeah to be clear i was talking about the ; issue

yeah to be clear i was talking about the `;` issue
Sign in to join this conversation.
Reviewers
No reviewers
ariadne
Labels
Clear labels   
bug

Something isn't working   
duplicate

This issue or pull request already exists   
enhancement

New feature or request   
good first issue

Good for newcomers   
help wanted

Extra attention is needed   
invalid

This doesn't seem right   
question

Further information is requested   
wontfix

This will not be worked on
No Label
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/libucontext#27
There is no content yet.
Delete Branch "qemu-support-v2"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?