Only add warnings and std flags if supported by compiler (autoconf) #145

ariadne · 2017-09-24T14:17:41Z

plicease commented

2017-09-24 14:17:41 +00:00

(Migrated from github.com)

This adds autoconf detection for the -Wall and -std= flags. I am proposing as a separate PR as it adds a developer dependency on autoconf-archive. If that is undesirable I can probably rework it.

This adds autoconf detection for the `-Wall` and `-std=` flags. I am proposing as a separate PR as it adds a developer dependency on `autoconf-archive`. If that is undesirable I can probably rework it.

ariadne commented

2017-09-24 18:46:06 +00:00

Would it be possible to include the autoconf-archive macros somehow?

plicease commented

2017-09-25 21:25:23 +00:00

(Migrated from github.com)

Are you asking if the macro can be bundled with pkgconf?

ariadne commented

2017-09-25 23:48:14 +00:00

yes, such as in acinclude.m4

yes, such as in `acinclude.m4`

plicease commented

2017-09-26 07:31:22 +00:00

(Migrated from github.com)

Rebased.

I bundled using AC_CONFIG_MACRO_DIRS as per this advice: https://www.gnu.org/software/automake/manual/html_node/Local-Macros.html
( if this is bad advice, please let me know :) )

I noticed that the bundled macro file includes license reference to GPL3 :( There is an "autoconf exception" for the license referred to here: https://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html . I am not a lawyer, so I can't say with certainty if that would force a license change, which (seems to me) would be unacceptable. My read is "autoconf exception" is fine for distributing the generated configure, but I am not sure about distributing just the m4 file.

Rebased. I bundled using AC_CONFIG_MACRO_DIRS as per this advice: https://www.gnu.org/software/automake/manual/html_node/Local-Macros.html ( if this is bad advice, please let me know :) ) I noticed that the bundled macro file includes license reference to GPL3 :( There is an "autoconf exception" for the license referred to here: https://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html . I am not a lawyer, so I can't say with certainty if that would force a license change, which (seems to me) would be unacceptable. My read is "autoconf exception" is fine for distributing the generated configure, but I am not sure about distributing just the m4 file.

Sign in to join this conversation.

No reviewers