ariadne
/
pkgconf
2
3
Fork 2
Code Issues 6 Pull Requests Projects Releases 2 Wiki Activity
Labels Milestones

Only add warnings and std flags if supported by compiler (autoconf) #145

Merged
plicease merged 2 commits from solaris-ac into master 5 years ago
Conversation 4 Commits 2 Files Changed 3
plicease commented 5 years ago (Migrated from github.com)
Owner

This adds autoconf detection for the -Wall and -std= flags. I am proposing as a separate PR as it adds a developer dependency on autoconf-archive. If that is undesirable I can probably rework it.

This adds autoconf detection for the `-Wall` and `-std=` flags. I am proposing as a separate PR as it adds a developer dependency on `autoconf-archive`. If that is undesirable I can probably rework it.
ariadne commented 5 years ago
Owner

Would it be possible to include the autoconf-archive macros somehow?

Would it be possible to include the autoconf-archive macros somehow?
plicease commented 5 years ago (Migrated from github.com)
Owner

Are you asking if the macro can be bundled with pkgconf?

Are you asking if the macro can be bundled with pkgconf?
ariadne commented 5 years ago
Owner

yes, such as in acinclude.m4

yes, such as in `acinclude.m4`
plicease commented 5 years ago (Migrated from github.com)
Owner

Rebased.

I bundled using AC_CONFIG_MACRO_DIRS as per this advice: https://www.gnu.org/software/automake/manual/html_node/Local-Macros.html
( if this is bad advice, please let me know :) )

I noticed that the bundled macro file includes license reference to GPL3 :( There is an "autoconf exception" for the license referred to here: https://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html . I am not a lawyer, so I can't say with certainty if that would force a license change, which (seems to me) would be unacceptable. My read is "autoconf exception" is fine for distributing the generated configure, but I am not sure about distributing just the m4 file.

Rebased. I bundled using AC_CONFIG_MACRO_DIRS as per this advice: https://www.gnu.org/software/automake/manual/html_node/Local-Macros.html ( if this is bad advice, please let me know :) ) I noticed that the bundled macro file includes license reference to GPL3 :( There is an "autoconf exception" for the license referred to here: https://www.gnu.org/software/autoconf-archive/ax_check_compile_flag.html . I am not a lawyer, so I can't say with certainty if that would force a license change, which (seems to me) would be unacceptable. My read is "autoconf exception" is fine for distributing the generated configure, but I am not sure about distributing just the m4 file.
The pull request has been merged as a8a65c7f6c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
bug duplicate enhancement invalid question wontfix
No Label bug duplicate enhancement invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#145
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'solaris-ac'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes