Do a better job cleaning up memory #239

Merged
ariadne merged 17 commits from dcbaker/pkgconf:free-memory into master 2 months ago

PR moved from github.

This is a lot of cleanup of memory handling in pkgconf and libpkgconf. With this series all of the unittests are green with the address sanitizer enabled, and the usage in Meson++ and Muon reports no leaks. So, success?

PR moved from [github](https://github.com/pkgconf/pkgconf/pull/254). This is a lot of cleanup of memory handling in pkgconf and libpkgconf. With this series all of the unittests are green with the address sanitizer enabled, and the usage in Meson++ and Muon reports no leaks. So, success?
dcbaker added 19 commits 2 months ago
7cd86508a3 dependency: add refcount trace to dependency
2f5a2c56d4 dependency: add a reference to dependency when adding to graph
7025581da8 cache: use pkgconf_dependency_free instead of just setting match = NULL
ee06ab42d2 main: cleanup when validating
7b3346206e dependency: unref dependency parent if it's set
36acd2e409 queue: don't collect static dependencies unless that's what we're looking for
d23dc2c183 cache: don't try to remove packages from the cache if it's NULL
c7b0f86815 cache: set the cache_table to NULL if empty
0c72b7cd41 ci: run meson test with the address sanitizer enabled
dcbaker changed title from Do a better job cleaning up memory to WIP: Do a better job cleaning up memory 2 months ago
Poster

I keep finding more issues with memory leaking (or me fixing it incorrectly), so I'm going to mark this as WIP for the moment.

I keep finding more issues with memory leaking (or me fixing it incorrectly), so I'm going to mark this as WIP for the moment.
dcbaker added 5 commits 2 months ago
Owner

Yeah, sadly libpkgconf API came after pkgconf the tool was written so there's a lot to clean up probably :)

Yeah, sadly libpkgconf API came after pkgconf the tool was written so there's a lot to clean up probably :)
dcbaker force-pushed free-memory from 116e367525 to 90232914cd 2 months ago
dcbaker changed title from WIP: Do a better job cleaning up memory to Do a better job cleaning up memory 2 months ago
dcbaker force-pushed free-memory from 90232914cd to 179a0560a6 2 months ago
ariadne approved these changes 2 months ago
ariadne merged commit b310728111 into master 2 months ago
dcbaker deleted branch free-memory 2 months ago

Reviewers

ariadne approved these changes 2 months ago
The pull request has been merged as b310728111.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#239
Loading…
There is no content yet.