Fix macro definition interfering with -Wmisleading-indentation #241

dcbaker · 2022-08-03T19:05:16Z

dcbaker commented

2022-08-03 19:05:16 +00:00

I found a GCC bug! (I'm just waiting for an account to report it).

In this case we can fix the issue by removing a doubled up semi-colon. I've also enabled the warning, because it's useful.

I found a GCC bug! (I'm just waiting for an account to report it). In this case we can fix the issue by removing a doubled up semi-colon. I've also enabled the warning, because it's useful.

dcbaker added 2 commits 2022-08-03 19:05:17 +00:00

96c61cbab0 libpkgconf: remove trailing ; from macro definition

GCC has a lovely bug (which I will report as soon as I have an account),
which causes -Wmisleading-indentation to miss cases of misleading
indentation after a `;;`, since the macro adds `;`, and in call cases
the caller also adds `;`, we end up with a double macro and gcc fails to
warn.

ci/woodpecker/pr/woodpecker Pipeline was successful Details

125a13d3b9 meson: add -Wmisleading-indentation

A useful warning when loop and conditional statements are allowed
without braces.

ariadne merged commit d240afe7d9 into master

2022-08-04 04:33:11 +00:00

ariadne referenced this issue from a commit

2022-08-04 04:33:12 +00:00

Merge pull request 'Fix macro definition interfering with -Wmisleading-indentation' (#241) from dcbaker/pkgconf:submit/misleading-indentation into master

dcbaker deleted branch submit/misleading-indentation

2022-08-04 18:22:09 +00:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#241