ariadne
/
pkgconf
3
6
Fork 4
Code Issues 6 Pull Requests 2 Projects Releases 2 Wiki Activity

meson: use a feature option for tests instead of boolean #244

Merged
ariadne merged 1 commits from dcbaker/pkgconf:tests-feature into master 2022-08-20 13:27:45 +00:00
Conversation 4 Commits 1 Files Changed 2
dcbaker commented 2022-08-17 18:15:58 +00:00

This allows tests to be autodetected gracefully, which is particularly
convenient for kyua and atf_sh which are fairly painful to build and
install by hand. Those who want to ensure tests are enabled or disabled
may pass -Dtests=enabled or -Dtests=disabled respectively.

This does require a modest bump in the required meson version to 0.49,
which was released at the end of 2018, so roughly 4 years ago.

This allows tests to be autodetected gracefully, which is particularly convenient for kyua and atf_sh which are fairly painful to build and install by hand. Those who want to ensure tests are enabled or disabled may pass `-Dtests=enabled` or `-Dtests=disabled` respectively. This does require a modest bump in the required meson version to 0.49, which was released at the end of 2018, so roughly 4 years ago.
dcbaker added 1 commit 2022-08-17 18:15:59 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
fa803c7ecd meson: use a feature option for tests instead of boolean 
This allows tests to be autodetected gracefully, which is particularly
convenient for kyua and atf_sh which are fairly painful to build and
install by hand. Those who want to ensure tests are enabled or disabled
may pass `-Dtests=enabled` or `-Dtests=disabled` respectively.

This does require a modest bump in the required meson version to 0.49,
which was released at the end of 2018, so roughly 4 years ago.
ariadne merged commit 0226cdda6d into master 2022-08-20 13:27:45 +00:00
pal1000 commented 2022-08-21 14:44:56 +00:00

@dcbaker @ariadne, this PR broke Windows build. I'll try fixing it.

@dcbaker @ariadne, this PR [broke Windows build](https://github.com/pkgconf/pkgconf/runs/7931986150?check_suite_focus=true). I'll try fixing it.
dcbaker commented 2022-08-21 16:12:33 +00:00
Poster

just delete the -Dtests=false argument. with this change it’s no longer needed

just delete the -Dtests=false argument. with this change it’s no longer needed
dcbaker deleted branch tests-feature 2022-08-21 16:12:41 +00:00
pal1000 commented 2022-08-21 16:27:56 +00:00

That's not enough. meson.build from tests directory tries to run chmod command unconditionally. That doesn't work on Windows.

That's not enough. meson.build from tests directory tries to run chmod command unconditionally. That doesn't work on Windows.
dcbaker commented 2022-08-21 17:23:14 +00:00
Poster

sigh, okay. ican fix it tomorrow if it lik prefer

sigh, okay. ican fix it tomorrow if it lik prefer
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
   
duplicate
   
enhancement
   
invalid
   
question
   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#244
There is no content yet.
Delete Branch "dcbaker/pkgconf:tests-feature"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?