ariadne
/
pkgconf
3
6
Fork 4
Code Issues 6 Pull Requests 2 Projects Releases 2 Wiki Activity

meson: fix tests on windows #247

Closed
dcbaker wants to merge 1 commits from dcbaker:submit/fix-windows-tests into master
pull from: dcbaker:submit/fix-windows-tests
merge into: ariadne:master
Conversation 0 Commits 1 Files Changed 1
dcbaker commented 2022-08-26 17:05:55 +00:00

The tests call chmod unconditionally, which is obviously problematic on
Windows. I have an idea for a more robust fix in Meson, but in the mean
time we can avoid the problem by not going into the test directory if
kyua and atf_sh aren't found or are disabled.

The tests call chmod unconditionally, which is obviously problematic on Windows. I have an idea for a more robust fix in Meson, but in the mean time we can avoid the problem by not going into the test directory if kyua and atf_sh aren't found or are disabled.
dcbaker added 1 commit 2022-08-26 17:05:55 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
1cd84fec98 meson: fix tests on windows 
The tests call chmod unconditionally, which is obviously problematic on
Windows. I have an idea for a more robust fix in Meson, but in the mean
time we can avoid the problem by not going into the test directory if
kyua and atf_sh aren't found or are disabled.
dcbaker closed this pull request 2022-08-26 17:06:32 +00:00
dcbaker deleted branch submit/fix-windows-tests 2022-08-26 17:06:37 +00:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
   
duplicate
   
enhancement
   
invalid
   
question
   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#247
There is no content yet.
Delete Branch "dcbaker:submit/fix-windows-tests"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?