ariadne
/
pkgconf
3
6
Fork 4
Code Issues 6 Pull Requests 2 Projects Releases 2 Wiki Activity

WIP: Fix MinGW escaping #249

Draft
dcbaker wants to merge 2 commits from dcbaker/pkgconf:submit/fix-mingw-escaping into master
pull from: dcbaker/pkgconf:submit/fix-mingw-escaping
merge into: ariadne:master
Conversation 1 Commits 2 Files Changed 4
dcbaker commented 2023-06-05 21:45:14 +00:00

We need to use POSIX handling of \\ in MinGW, not the Windows rules.

I'm kinda expecting the test I added to fail as I don't have Kyua and it isn't available for MinGW either

Fixes: #238

We need to use POSIX handling of `\\` in MinGW, not the Windows rules. I'm kinda expecting the test I added to fail as I don't have Kyua and it isn't available for MinGW either Fixes: #238
dcbaker added 2 commits 2023-06-05 21:45:15 +00:00
ci/woodpecker/pr/woodpecker Pipeline was successful Details
6de71767ab fragment: Mingw needs to use POSIX handling for `\\` 
Otherwise it won't correctly escape things like spaces, and can print
out the `\` literal escaping nothing, which causes most shell lexers to
choke.

Fixes: #238
dcbaker changed title from Fix MinGW escaping to WIP: Fix MinGW escaping 2023-06-07 17:37:11 +00:00
dcbaker commented 2023-06-07 17:38:06 +00:00
Poster

After some discussion with Lazka, we're wondering if the conditional behavior is wrong in general, so I need to run some tests with MSVC. I've marked this as WIP in the mean time

After some discussion with Lazka, we're wondering if the conditional behavior is wrong in general, so I need to run some tests with MSVC. I've marked this as WIP in the mean time
dcbaker force-pushed submit/fix-mingw-escaping from 6de71767ab to 68e3f24000 2023-06-08 19:02:46 +00:00 Compare
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b dcbaker-submit/fix-mingw-escaping master
git pull submit/fix-mingw-escaping

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff dcbaker-submit/fix-mingw-escaping
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
   
duplicate
   
enhancement
   
invalid
   
question
   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#249
There is no content yet.
Delete Branch "dcbaker/pkgconf:submit/fix-mingw-escaping"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?